Skip to content
This repository was archived by the owner on May 28, 2026. It is now read-only.

T421660: eslint enforce yml/no-empty-document#177

Merged
samwilson merged 1 commit into
wikimedia:mainfrom
okerekechinweotito:yml-no-empty-document
Apr 16, 2026
Merged

T421660: eslint enforce yml/no-empty-document#177
samwilson merged 1 commit into
wikimedia:mainfrom
okerekechinweotito:yml-no-empty-document

Conversation

@okerekechinweotito

@okerekechinweotito okerekechinweotito commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Related Phabricator Task - T421660

the yaml documents have commented out content in them. I am not sure deleting the files will be an accepted option so I have added the ~ character to make eslint see them as non-empty

  • remove yml/no-empty-document from .eslintrc.json
  • fix yml/no-empty-document errors
  • npm run test passes

@okerekechinweotito okerekechinweotito force-pushed the yml-no-empty-document branch 2 times, most recently from 53e219d to ce7df59 Compare April 15, 2026 10:16
@samwilson

Copy link
Copy Markdown
Member

Are these three files needed at all? If we don't have any config for them, it might be best to remove them. What do you think?

@okerekechinweotito

okerekechinweotito commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Are these three files needed at all? If we don't have any config for them, it might be best to remove them. What do you think?

I agree i think the files can be safely deleted. for any future config their use is well documented, i found some docs references to them if need be

webpack_encore.yaml

deprecations.yaml

@samwilson samwilson merged commit 6fd0107 into wikimedia:main Apr 16, 2026
4 checks passed
@samwilson

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants