This repository was archived by the owner on May 28, 2026. It is now read-only.
T421660: eslint enforce yml/no-empty-document#177
Merged
samwilson merged 1 commit intoApr 16, 2026
Conversation
53e219d to
ce7df59
Compare
Member
|
Are these three files needed at all? If we don't have any config for them, it might be best to remove them. What do you think? |
Contributor
Author
I agree i think the files can be safely deleted. for any future config their use is well documented, i found some docs references to them if need be webpack_encore.yaml deprecations.yaml |
ce7df59 to
ca9e5fd
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Phabricator Task - T421660
the yaml documents have commented out content in them. I am not sure deleting the files will be an accepted option so I have added the
~character to make eslint see them asnon-emptyyml/no-empty-documentfrom .eslintrc.jsonyml/no-empty-documenterrorsnpm run testpasses