T421660: eslint enforce no-new

.eslintrc.json

@@ -13,7 +13,6 @@
 	},
 	"rules": {
 		"no-jquery/no-global-selector": "warn",
-		"no-new": "warn",
 		"yml/no-empty-document": "warn",
 		"yml/no-empty-mapping-value": "warn"
 	}

assets/app.js

@@ -3,9 +3,9 @@
 import 'select2';
 
 const $ = require( 'jquery' );
 const $select2 = $( '#lang' );
 let selectedLanguages = [];
 const $lineDetectionSelect = $( '#line-id' );
 let lineModels = null;
 
 const Cropper = require( 'cropperjs' );
@@ -70,7 +70,7 @@
 
 	// append static options
 	staticOptionData.slice( 0, 2 ).forEach( ( staticOption ) => {
 		$lineDetectionSelect.append( new Option( staticOption.text, staticOption.value, staticOption.value === null, false ) );
 	} );
 
 	// append all other line detection models as options
@@ -86,7 +86,7 @@
 	fetchLineModelsJSON();
 
 	// Remove nojs class, for styling non-Javascript users.
 	$( 'html' ).removeClass( 'nojs' );
 
 	// Initiate Select2, which allows dynamic entry of languages.
 	$select2.select2( {
@@ -111,24 +111,24 @@
 	const previousDataPlaceholder = $select2.attr( 'data-placeholder' );
 
 	// Show engine-specific options.
 	$( '[name=engine]' ).on( 'change', ( e ) => {
 		const engine = e.target.value;
 		updateSelect2Options( engine );
 		$( '.engine-options' ).addClass( 'hidden' );
 		$( `#${ engine }-options` ).removeClass( 'hidden' );
 		if ( engine === 'tesseract' || engine === 'google' ) {
 			$select2.prop( 'required', false );
 			$select2.attr( 'data-placeholder', previousDataPlaceholder );
 			$select2.data( 'select2' ).selection.placeholder.text = previousDataPlaceholder;
 			$( '#transkribus-lang-label' ).addClass( 'hidden' );
 			$( '#optional-lang-label' ).removeClass( 'hidden' );
 		} else {
 			updateLineModelOptions();
 			$( '#transkribus-help' ).removeClass( 'hidden' );
 			$select2.prop( 'required', true );
 			$select2.attr( 'data-placeholder', '' );
 			$select2.data( 'select2' ).selection.placeholder.text = '';
 			$( '#optional-lang-label' ).addClass( 'hidden' );
 			$( '#transkribus-lang-label' ).removeClass( 'hidden' );
 		}
 	} );
@@ -173,7 +173,7 @@
 			width = document.querySelector( '[name="crop[width]"]' ),
 			height = document.querySelector( '[name="crop[height]"]' ),
 			$modeButtons = $( '.drag-mode' );
-		new Cropper( img, {
+		const cropper = new Cropper( img, {
 			viewMode: 2,
 			dragMode: 'move',
 			// Remove double-click drag mode toggling, because we've got buttons for that.
@@ -184,14 +184,14 @@
 			ready() {
 				// Make textarea match height of image.
 				$( '#text' ).css( {
-					height: this.cropper.getContainerData().height
+					height: cropper.getContainerData().height
 				} );
 				// React to changes in the crop-mode buttons.
 				$modeButtons.on( 'click', ( event ) => {
 					const $button = $( event.currentTarget );
 					$modeButtons.removeClass( 'active' );
 					$button.addClass( 'active' );
-					this.cropper.setDragMode( $button.data( 'drag-mode' ) );
+					cropper.setDragMode( $button.data( 'drag-mode' ) );
 				} );
 			},
 			data: {