[WV-4251]When searching for a person, the donorsOnTeam value gets very large [Team Review]#160
Merged
Merged
Conversation
DaleMcGrew
changed the title
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/weconnect/issues does this fix?
[WV4251]When searching for a person, the donorsOnTeam value gets very large
Changes included this pull request?
src/js/components/Team/TeamHeader.jsx
Fixed the numberOfTeamMembers value so it correctly ignores the search text. Previously, the count was being updated based on filtered results, which caused it to change when a search was applied.
In the comparison below, the donor percentage is now displayed correctly. The left side shows the behavior before the fix (from the QA WeConnect client), while the right side shows the corrected behavior after applying the fix (from the local WeConnect client).