Add Django 5.2 and Python 3.13 to tests and docs#580
Conversation
…use django 5.2 and python 3.13
| run: | | ||
| poetry run pip install --upgrade pip setuptools | ||
| poetry install | ||
| poetry install --no-root |
There was a problem hiding this comment.
We need the project as well here
| poetry install --no-root | |
| poetry install |
|
|
||
| ```bash | ||
| poetry install | ||
| poetry install --no-root |
There was a problem hiding this comment.
| poetry install --no-root | |
| poetry install |
| - poetry config virtualenvs.create false | ||
| post_install: | ||
| - . "$(pwd | rev | sed 's/stuokcehc/svne/' | rev)/bin/activate" && poetry install --only main --only docs | ||
| - . "$(pwd | rev | sed 's/stuokcehc/svne/' | rev)/bin/activate" && poetry install --no-root --only main --only docs |
There was a problem hiding this comment.
| - . "$(pwd | rev | sed 's/stuokcehc/svne/' | rev)/bin/activate" && poetry install --no-root --only main --only docs | |
| - . "$(pwd | rev | sed 's/stuokcehc/svne/' | rev)/bin/activate" && poetry install --only main --only docs |
| @@ -1,21 +1,18 @@ | |||
| [tool.poetry] | |||
| [project] | |||
There was a problem hiding this comment.
Please, revert pyproject.toml changes to this new PEP thing, it does not work with dependabot. And we kinda need it :)
| django = [ | ||
| { version = "^4.2", python = "<3.10" }, | ||
| { version = "^5.0", python = ">=3.10" }, | ||
| { version = "^5.2", python = ">=3.10" }, |
There was a problem hiding this comment.
We can instead drop 3.9 support for newer versions.
| fail-fast: false | ||
| matrix: | ||
| python-version: ['3.10', '3.11', '3.12'] | ||
| python-version: ['3.10', '3.11', '3.12', '3.13'] |
…ort error on tomlib. revert to old poetry pyproject file format. remove no-root from poetry installs
|
I think I got all the changes in, let me know if I missed anything from your review! |
| def _get_project_meta(): | ||
| with open('../pyproject.toml', mode='rb') as pyproject: | ||
| return tomllib.load(pyproject)['tool']['poetry'] | ||
| import os |
There was a problem hiding this comment.
I think that this can be reverted, we always have ['tool']['poetry'] key :)
| project = str(pkg_meta.get('name', 'django-split-settings')) | ||
| # The short X.Y version | ||
| version = str(pkg_meta['version']) | ||
| version = str(pkg_meta.get('version', '0.0.1')) |
There was a problem hiding this comment.
Same here, version always exists.
| copyright = '2013, 2General Oy' # noqa: WPS125 | ||
| author = 'Nikita Sobolev' | ||
|
|
||
| project = str(pkg_meta.get('name', 'django-split-settings')) |
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thanks a lot! This is really helpful! 👍
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 41 44 +3
Branches 7 7
=========================================
+ Hits 41 44 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Oh, you can just drop |
|
It looks like Do you still want to drop it or just use the updated version? |
|
Also needed to update very old pinned version of |
| mypy = "^1.10" | ||
| wemake-python-styleguide = "^0.19" | ||
| wemake-python-styleguide = "^1.0" | ||
| flake8-pytest-style = "^2.0" |
There was a problem hiding this comment.
You can also drop flake8-pytest-style
| wemake-python-styleguide = "^1.0" | ||
| flake8-pytest-style = "^2.0" | ||
| nitpick = "^0.35" | ||
| nitpick = "^0.38" |
2 participants
Tested the project against Django 5.2 and Python 3.13
Updated the docs to demonstrate that its compatible with both.
Updated to the latest poetry version and fixed pyproject.toml accordingly.
Updated contributing with updated commands for install and mypy checks.