Fixed a bug when combined with certain add-ons.#46
Open
ebisuke wants to merge 1 commit into
Open
Conversation
Author
|
すみません、saquのスコープをlocalにしたのは別の問題が起きそうです。 |
Owner
|
コンストラクタの中身を遅延させる感じですかね。SaveaQuest.newの中身をGAME_STARTイベントハンドラとかに移譲させれば......? すみません、ちゃんと自分で調べてやらないといけませんね |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対策の本質としてはSaveQuestのインスタンス生成をlua読み込み時からON_INITまで遅延させています。
明確な理由はわかりませんが、本対策にて特定のアドオンと組み合わせたときの
クエストが表示されない問題は解消できております。
お手数をおかけしますが、ご確認願います。