Add missing test coverage for analyzerMode: "server" - #740
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe changes add server-mode test coverage. The tests verify that Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The server-mode coverage verifies the reused-plugin update path, with no concrete merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Out of Scope Changes checkExplanation The PR also migrates the plugin to Webpack's infrastructure logger and adds a changeset that deprecates
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
The PR body and the PR title seems entirely off compared to what this PR has. Looks like a new PR would be better to have as this PR was written from your |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 86.75% 87.56% +0.81%
==========================================
Files 17 17
Lines 1110 1110
Branches 406 406
==========================================
+ Hits 963 972 +9
+ Misses 134 126 -8
+ Partials 13 12 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
analyzerMode: "server"
valscion
left a comment
There was a problem hiding this comment.
The branch at least needs to be made up-to-date with latest main here so it won't have the changeset and implications that there's some feature work going on in here. Also drop out package-lock.json changes.
6da2211 to
853d8fd
Compare
|
@valscion I have rebased the branch directly on top of the latest upstream/main and dropped both the resurrected changeset file and the package-lock.json changes. The PR now contains only the test coverage additions in test/plugin.js. |
Summary
Fixes #727
Adds missing test coverage for
analyzerMode: "server"intest/plugin.js:openAnalyzer: falseandanalyzerPort: "auto", verifying that the server starts listening and invokesanalyzerUrlwith the bound host and port.servermode, verifying thatupdateChartDatais called with the subsequent compiler's bundle directory (covering the logic introduced in fix: preserve compiler paths for shared plugin instances #725).What kind of change does this PR introduce?
test
Did you add tests for your changes?
Yes, this PR adds test coverage in
test/plugin.js.Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A (test additions only)
Use of AI
No