Repository navigation
Run the test suite on Windows in CI - #102
Merged
Merged
Conversation
- Move the demo app build (project or package mode) from the Dockerfile into build-demo.sh, shared by the Linux container and Windows. - Add a windows-latest job that runs build-demo.sh and run-tests.sh with Git Bash, against both the project and the packed .nupkg, using the wkhtmltopdf/wkhtmltoimage .exe files already in the repo. - .gitattributes keeps .sh files LF so bash can run them on Windows checkouts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-latestjob runs the full suite (5 unit + 5 integration tests) against both the library project and the packed.nupkg. It uses thewkhtmltopdf.exe/wkhtmltoimage.exefiles already in the repo, the same setup Windows users have.Rotativa.AspNetCore.Tests/build-demo.sh. The Linux container and the Windows job both run it with bash; Windows uses Git Bash. It also strips the\rfromdotnetoutput on Windows..gitattributes..shfiles are kept with LF line endings, because the Windows runner checks files out with CRLF and bash can't run scripts with CRLF.The Windows job runs the demo app on plain HTTP (
ROTATIVA_DEMO_URL=http://localhost:5000), so the runner doesn't need to trust the development HTTPS certificate. Chrome runs headless becauseCI=true.Test plan
.deps.jsonshowsproject/packagerespectively.🤖 Generated with Claude Code