Repository navigation
Add .NET 10 support, cross-platform tests and CI - #100
Merged
Merged
Conversation
- Target net10.0 alongside the existing frameworks. - Merge the per-framework FrameworkReference blocks into one that covers every target except netstandard2.0. - Bump Microsoft.AspNetCore.Mvc for netstandard2.0 from 2.2.0 to 2.3.13, which resolves patched Newtonsoft.Json, System.Text.Encodings.Web and System.Security.Cryptography.Xml (NuGet audit NU1902-NU1904). - Version 1.5.0 and updated package metadata. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- DemoApp and test project target net10.0; test packages updated, and the redundant Microsoft.AspNetCore.Mvc.ViewFeatures 2.2.0 reference removed. - PdfContains compares on normalized whitespace (macOS wkhtmltopdf emits tabs between words). - Image tests check PNG/JPEG signatures instead of System.Drawing, which is Windows-only. - Integration tests read ROTATIVA_DEMO_URL, ROTATIVA_TESTS_HEADLESS (or CI) and ROTATIVA_CHROME_BINARY, and now quit Chrome after each test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Dockerfile (Debian 12, .NET 10, Chromium, wkhtmltopdf 0.12.6.1) and run-tests.sh that starts the demo app and runs the full suite. - Workflow builds the library for all target frameworks and runs the tests in the container on pushes to master and pull requests. - Ignore local non-Windows wkhtmltopdf/wkhtmltoimage binaries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
webgio
commented
Oct 8, 2026
webgio
left a comment
webgio
left a comment
Owner
Author
There was a problem hiding this comment.
All seems good to go into master
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net10.0. No source changes were needed: the conditional code already usesNET6_0_OR_GREATER/NET5_0_OR_GREATER. The per-frameworkFrameworkReferenceblocks are merged into one, so future versions only need a new entry in<TargetFrameworks>. Version bumped to 1.5.0.Microsoft.AspNetCore.Mvcgoes from 2.2.0 to 2.3.13, which resolves patched versions of Newtonsoft.Json (13.0.1), System.Text.Encodings.Web (8.0.0) and System.Security.Cryptography.Xml (8.0.4). That clears the NuGet audit warnings (one critical, one high, one moderate).Things to note
PdfContainsnow compares on normalized whitespace.System.Drawing, which only works on Windows. This confirms the file type but doesn't decode the whole image.ROTATIVA_DEMO_URL(defaulthttps://localhost:56246),ROTATIVA_TESTS_HEADLESS(automatic whenCI=true),ROTATIVA_CHROME_BINARY.Test plan
lib/net10.0/Rotativa.AspNetCore.dll..exebinaries.🤖 Generated with Claude Code