Skip to content

fix: enable mimalloc local_dynamic_tls on macOS#13992

Open
hardfist wants to merge 1 commit into
mainfrom
codex/mimalloc-local-dynamic-tls-macos
Open

fix: enable mimalloc local_dynamic_tls on macOS#13992
hardfist wants to merge 1 commit into
mainfrom
codex/mimalloc-local-dynamic-tls-macos

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

Summary

  • Enable mimalloc local_dynamic_tls for macOS in rspack_allocator.
  • Keep xtask/benchmark mimalloc features aligned with the allocator crate.

Related links

N/A

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Validation:

  • pnpm exec taplo fmt --check crates/rspack_allocator/Cargo.toml xtask/benchmark/Cargo.toml
  • cargo check -p rspack_allocator
  • cargo check -p rspack_benchmark --lib

Copilot AI review requested due to automatic review settings May 11, 2026 08:27
@github-actions github-actions Bot added the release: bug fix release: bug related release(mr only) label May 11, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Enables the mimalloc local_dynamic_tls feature on macOS and keeps allocator-related mimalloc feature flags consistent between the allocator crate and the benchmarking xtask.

Changes:

  • Enable mimalloc local_dynamic_tls on macOS in crates/rspack_allocator.
  • Mirror the same mimalloc macOS feature flags in xtask/benchmark.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
xtask/benchmark/Cargo.toml Enables local_dynamic_tls for mimalloc on macOS to match allocator configuration.
crates/rspack_allocator/Cargo.toml Enables local_dynamic_tls for mimalloc on macOS in the allocator crate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread xtask/benchmark/Cargo.toml
Comment thread crates/rspack_allocator/Cargo.toml
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

📦 Binary Size-limit

Comparing f8cf2e3 to feat: drop inactive branch dependencies for inlined booleans (#13863) by Fy

🙈 Size remains the same at 61.97MB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 2 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB +2.6 KB (0.1%)
react-10k 5.7 MB 0
react-1k 826.3 KB 0
rome 1.6 MB 0
react-5k 2.7 MB 0
ui-components 4.8 MB +14.0 B (0.0%)
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

📌 Baseline Commit: fafedfd743 | PR: #13863

Metric Current Baseline Change
📊 Total Size 1.7 MB 1.7 MB +2.6 KB (0.1%)
📄 JavaScript 1.7 MB 1.7 MB +2.6 KB (0.1%)
🎨 CSS 0 B 0 B 0
🌐 HTML 289.0 B 289.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: popular-libs Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: fafedfd743 | PR: #13863

Metric Current Baseline Change
📊 Total Size 4.8 MB 4.8 MB +14.0 B (0.0%)
📄 JavaScript 4.7 MB 4.7 MB +14.0 B (0.0%)
🎨 CSS 107.0 KB 107.0 KB 0
🌐 HTML 328.0 B 328.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@hardfist hardfist force-pushed the codex/mimalloc-local-dynamic-tls-macos branch from 1415673 to f8cf2e3 Compare May 11, 2026 08:44
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 11, 2026

Merging this PR will not alter performance

✅ 34 untouched benchmarks
⏩ 25 skipped benchmarks1


Comparing codex/mimalloc-local-dynamic-tls-macos (f8cf2e3) with main (fafedfd)

Open in CodSpeed

Footnotes

  1. 25 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants