fix: enable mimalloc local_dynamic_tls on macOS#13992
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Enables the mimalloc local_dynamic_tls feature on macOS and keeps allocator-related mimalloc feature flags consistent between the allocator crate and the benchmarking xtask.
Changes:
- Enable
mimalloclocal_dynamic_tlson macOS incrates/rspack_allocator. - Mirror the same
mimallocmacOS feature flags inxtask/benchmark.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
xtask/benchmark/Cargo.toml |
Enables local_dynamic_tls for mimalloc on macOS to match allocator configuration. |
crates/rspack_allocator/Cargo.toml |
Enables local_dynamic_tls for mimalloc on macOS in the allocator crate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Binary Size-limit
🙈 Size remains the same at 61.97MB |
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 2 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 popular-libsPath:
📦 Download Diff Report: popular-libs Bundle Diff 📁 ui-componentsPath:
📦 Download Diff Report: ui-components Bundle Diff Generated by Rsdoctor GitHub Action |
1415673 to
f8cf2e3
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Summary
local_dynamic_tlsfor macOS inrspack_allocator.xtask/benchmarkmimalloc features aligned with the allocator crate.Related links
N/A
Checklist
Validation:
pnpm exec taplo fmt --check crates/rspack_allocator/Cargo.toml xtask/benchmark/Cargo.tomlcargo check -p rspack_allocatorcargo check -p rspack_benchmark --lib