Skip to content

test: restore persistent cache CodSpeed profile grouping#13989

Draft
hardfist wants to merge 1 commit into
mainfrom
codex/fix-persistent-cache-codspeed-profile
Draft

test: restore persistent cache CodSpeed profile grouping#13989
hardfist wants to merge 1 commit into
mainfrom
codex/fix-persistent-cache-codspeed-profile

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

Summary

  • Restore persistent cache restore benchmarks to the original groups/persistent_cache.rs::persistent_cache::persistent_cache_benchmark Criterion group.
  • Keep the split case entrypoints for the other benchmarks, but remove the persistent cache case wrappers so CodSpeed profile data is attached to the original restore benchmark entrypoint.
  • This targets the test: split benchmark case entrypoints #13971 CodSpeed profile display regression where the new persistent cache restore entries no longer show the full build-stage callgraph even though the raw callgrind profile part still contains those frames.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions
Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing fa7ec6b to test: print benchmark compilation errors (#13984) by hardfist

🙈 Size remains the same at 61.93MB

@github-actions
Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (971ff8e958) does not have baseline artifacts. Using commit dabb7d0ea4 for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 6 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB 0
react-10k 5.7 MB 0
react-1k 826.3 KB 0
react-5k 2.7 MB 0
ui-components 4.8 MB 0
rome 1.6 MB 0

Generated by Rsdoctor GitHub Action

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 11, 2026

Merging this PR will not alter performance

✅ 34 untouched benchmarks
⏩ 25 skipped benchmarks1


Comparing codex/fix-persistent-cache-codspeed-profile (fa7ec6b) with main (dabb7d0)2

Open in CodSpeed

Footnotes

  1. 25 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (be036ab) during the generation of this report, so dabb7d0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant