feat(plugin-solid): support for Solid v2#7608
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08bfdeb945
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Code Review
This pull request migrates the Solid.js plugin and templates to support Solid v2 beta, which involves updating imports to @solidjs/web and adjusting dependency versions. Additionally, the project is upgraded to pnpm v11 and workspace build settings are modified in pnpm-workspace.yaml. Reviewer feedback recommends using less restrictive version ranges (using the caret ^) for Solid-related dependencies and peer dependencies to ensure compatibility with the final v2 release.
There was a problem hiding this comment.
Pull request overview
This PR updates the Solid-related ecosystem in the repo to target Solid v2 (beta) by switching runtime imports to @solidjs/web and aligning dependencies across templates, examples, and e2e coverage. It also updates the workspace/tooling baseline by bumping pnpm and refreshing the lockfile/config.
Changes:
- Update Solid runtime imports from
solid-js/webto@solidjs/webin templates, examples, and e2e cases. - Bump Solid-related dependencies (e.g.
solid-js,@solidjs/web,babel-preset-solid,solid-refresh) to Solid v2 beta-compatible ranges. - Update pnpm tooling/config (
packageManager/engines, workspace settings, lockfile format).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds pnpm workspace settings related to builds and release-age exclusions. |
| pnpm-lock.yaml | Updates lockfile for pnpm 11 and Solid v2 dependency graph changes. |
| packages/plugin-solid/package.json | Updates plugin version and Solid v2-related dependency/peerDependency declarations. |
| packages/create-rsbuild/template-solid-ts/src/index.tsx | Switches Solid render import to @solidjs/web. |
| packages/create-rsbuild/template-solid-ts/package.json | Updates Solid dependencies to v2 beta ranges and adds @solidjs/web. |
| packages/create-rsbuild/template-solid-js/src/index.jsx | Switches Solid render import to @solidjs/web. |
| packages/create-rsbuild/template-solid-js/package.json | Updates Solid dependencies to v2 beta ranges and adds @solidjs/web. |
| package.json | Bumps pnpm version/engine requirement. |
| examples/solid/src/index.jsx | Switches Solid render import to @solidjs/web. |
| examples/solid/package.json | Updates Solid dependencies to v2 beta ranges and adds @solidjs/web. |
| e2e/package.json | Updates Solid dependencies for e2e to v2 beta ranges and adds @solidjs/web. |
| e2e/cases/plugin-solid/ts/src/index.ts | Switches Solid render import to @solidjs/web. |
| e2e/cases/plugin-solid/stylus/src/index.js | Switches Solid render import to @solidjs/web. |
| e2e/cases/plugin-solid/scss/src/index.js | Switches Solid render import to @solidjs/web. |
| e2e/cases/plugin-solid/ref/src/index.jsx | Switches Solid render import to @solidjs/web. |
| e2e/cases/plugin-solid/less/src/index.js | Switches Solid render import to @solidjs/web. |
| e2e/cases/plugin-solid/hmr/src/index.jsx | Switches Solid render import to @solidjs/web. |
| e2e/cases/plugin-solid/basic/src/index.js | Switches Solid render import to @solidjs/web. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
cc @brenelz |
Summary
Released: @rsbuild/plugin-solid 2.0.0-beta.0