chore(infra): integrate skills-package-manager via prepare script#7565
chore(infra): integrate skills-package-manager via prepare script#7565SoonIter wants to merge 10 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates skills-package-manager into the project by adding it as a development dependency, initializing its configuration and lock files, and updating the .gitignore to exclude the skills installation directory. The prepare script in package.json was also updated to automatically run the skills installation. Feedback was provided regarding the potential for the prepare script to fail in production or restricted environments where dev dependencies are missing or the registry is unreachable, suggesting a more resilient implementation for the installation step.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Integrates skills-package-manager into the repo so agent skills are installed/synced automatically via the root prepare script during pnpm install.
Changes:
- Add
skills-package-manager@0.9.0and runskills-package-manager installinprepare. - Introduce
skills.jsonandskills-lock.yamlto define and lock skill sources. - Ignore generated
.agents/skills/output in.gitignore.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills.json | Adds the skills manifest (schema, install directory, and linked skills). |
| skills-lock.yaml | Adds a lockfile capturing resolved skill sources (link resolutions). |
| package.json | Installs skills during prepare and adds the tool as a dev dependency. |
| .gitignore | Prevents generated .agents/skills/ content from being committed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SoonIter
changed the title
SoonIter
force-pushed
the
wip/trapped-yttrium-6d38
branch
from
3a10697 to
e819c1e
Compare
There was a problem hiding this comment.
Can we lease these skills in the .agent/skills folder?
## Summary - Add `local:` skill specifiers for existing user-owned skill directories. - Install `local:` skills in place without copying, replacing, patching, or pruning their source directories. - Link agent targets directly to the local source directory and maintain `.gitignore` unignore rules for repo-local skills. - Update tests, docs, and the bundled `skills-package-manager-cli` guidance. ## Related Links web-infra-dev/rsbuild#7565 <!-- Provide links to related issues, discussions, or design notes --> ## Checklist <!-- Check and mark with an "x" --> - [x] Tests updated (or not required). - [x] Documentation updated (or not required). Testing: - `pnpm build` - `pnpm test` - `pnpm build:website` - `pnpm check` (passes with existing warnings)
SoonIter
force-pushed
the
wip/trapped-yttrium-6d38
branch
from
5bc0a08 to
91628ea
Compare
Summary
preparenow generates.agents/skills/**on every installThis PR integrates
skills-package-managerinto the monorepo using thepreparelifecycle script, so that agent skills are automatically synchronized on everypnpm install.skills-package-manageras a dev dependency.preparescript to runskills-package-manager installbefore existing setup steps.skills.jsonandskills-lock.yamlfor skill manifest and lockfile management..agents/skills/directory in.gitignore.https://skills-package-manager.site/getting-started.html?page=2
Benefits
Avoid committing generated
.agents/skillsfiles for every skill update.skills-package-managerkeeps skills managed byskills.jsonandskills-lock.yaml, so updates are quieter and reproducible.npx skills-package-manager updateto upgrade skills in one command.link:, and archive-based skill sources.