Derive print IPC channels from typed registry#281
Conversation
|
Warning Review limit reached
More reviews will be available in 53 minutes and 37 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: wcpos/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7274d5b6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "test:serial-printer": "ts-node src/main/serial-printer.test.ts" | ||
| }, | ||
| "dependencies": { | ||
| "@wcpos/printer": "workspace:*", |
There was a problem hiding this comment.
Use an installable dependency for standalone workflows
The dependency is added with the workspace protocol, but this repository’s CI/release jobs install after checking out only wcpos/electron: .github/workflows/test.yml runs pnpm install at line 43, and the publish jobs in .github/workflows/tag-and-release.yml run npm install (for example lines 88, 132, 172, and 244). I verified the CLI behavior in a temp package: npm install fails with EUNSUPPORTEDPROTOCOL: Unsupported URL Type "workspace:", while pnpm install fails with ERR_PNPM_WORKSPACE_PKG_NOT_FOUND when the workspace package is absent. This blocks the standalone Electron test/release workflows unless they are changed to check out the monorepo or this dependency is made installable in this repo.
Useful? React with 👍 / 👎.
Summary
handleIpchelper.@wcpos/printer/ipc-channels..ctsregistry subpath bundles correctly from the monorepo workspace.Design decisions (preserve through rebases)
@wcpos/printer/ipc-channels;test:preloadverifies ts-node can require the.ctssubpath.rxStoragefrom the preload invoke allowlist — the live RxDB bridge uses dynamicrxdb-ipc-renderer-storage|<key>channels; the onlyrxStoragehandler is in a.bakfile.Companion PRs / cross-repo
@wcpos/printer/ipc-channelsregistry and updates theapps/electronsubmodule pointer to this commit.Test plan
pnpm --filter @wcpos/app-electron ts:checkfrom the monorepo worktree.pnpm --filter @wcpos/app-electron lintand confirm there are 0 errors (warnings are pre-existing require/no-unused warnings).pnpm --filter @wcpos/app-electron test.test:preload,test:printer-discovery,test:serial-printer,test:winspool-printer.pnpm --filter @wcpos/printer exec tsc --noEmit -p tsconfig.jsonandpnpm --filter @wcpos/printer exec vitest run.Known blockers
@wcpos/printer/ipc-channelssubpath.🤖 Generated with Claude Code