Repository navigation
chore(🐙): include <utility> in GPUNativeBufferWrapper.h, as cpplint requires - #559
Merged
wcandillon merged 1 commit intoOct 16, 2026
Conversation
…equires The header calls std::move without including <utility>, which fails the cpplint job on main: "Add #include <utility> for move [build/include_what_you_use]".
|
🎉 This PR is included in version 0.16.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
cpplintjob has failed onmainsince #552 added it:cpp/rnwgpu/api/GPUNativeBufferWrapper.h:93: Add #include <utility> for move [build/include_what_you_use] [4](run). The header callsstd::moveand includes only<memory>and<string>, so the job fails on every PR.Solution
Include
<utility>with the header's other standard includes.Tests
The
cpplintjob is the check.Verification
npm run cpplintinpackages/webgpureportsTotal errors found: 1onmain(c0d4b193) and no error with this change.