New version of numpy causing issues with scalars and id arrays#29
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 38 38
Lines 3726 3726
=======================================
Hits 3516 3516
Misses 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avdudchenko
approved these changes
Jan 30, 2026
avdudchenko
left a comment
avdudchenko
left a comment
Contributor
There was a problem hiding this comment.
LGTM - for note, we disabled MPI tests in Linux due to GH runner failure to install pympi - should revisit this in a different PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the line
num_total_samples = int(np.ceil(scale_factor * n_samples_remaining))causes an error in WaterTAP:FAILED tutorials/parameter_sweep_demo.ipynb::parameter_sweep_demo.ipynb - TypeError: only 0-dimensional arrays can be converted to Python scalarsthis is fixed if the item is pulled from
(scale_factor * n_samples_remaining)before casting to an np.ceil is applied.