Standardize Testing#43
Draft
jakechurchi wants to merge 15 commits into
Draft
Conversation
added 8 commits
January 21, 2026 13:28
…d components only checks
…nity values for ro stage tests
jakechurchi
commented
Feb 4, 2026
Collaborator
Author
There was a problem hiding this comment.
Maybe just delete this file so there aren't any conflicts with the one created in PR #42
| raise ValueError("dose must be provided to set_chem_addition_op_conditions") | ||
|
|
||
| else: | ||
| dose = dose * pyunits.mg / pyunits.L |
Collaborator
Author
There was a problem hiding this comment.
This allows the dose to be provided in main() without causing a units error
| units: kg/m**3 | ||
| feed_conductivity: | ||
| value: 1055 | ||
| value: 1055 # Check this value! |
Collaborator
Author
There was a problem hiding this comment.
Looking at raw data, I think it's probably like 1020... Not sure if we should change it at this point.
| ) | ||
|
|
||
|
|
||
| # Could add test for passing different costing units. Right now, only USD_2021 / gallon is supported. |
Collaborator
Author
There was a problem hiding this comment.
The pytest approx should be on the expected values due to milestone wording.
So rel = 0.15 --> approx on expected value
rel = 1e3 --> approx on the model output value
added 7 commits
February 18, 2026 17:10
…arate file for finding porosity value
…rrently fails b/c A and B are very different from spec sheet conditions
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will move all tests that area comparisons to data into "test_day" files. component test files will only check the model runs and solves as expected.