API: Respond with HTTP 400 to POST requests with no/multiple file#2130
Merged
Conversation
deniak
approved these changes
Jun 25, 2026
kfranqueiro
added a commit
that referenced
this pull request
Jun 25, 2026
kfranqueiro
added a commit
that referenced
this pull request
Jun 29, 2026
kfranqueiro
added a commit
that referenced
this pull request
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates logic in
lib/api.tsto respond with an actual 400 status code rather than a 200 OK status withstatus: 400in the response body, when thefileparameter is missing or multiple values are passed.(In 12.x, this currently responds with 200 OK containing
status: 500in the body, which is doubly incorrect, since this is a user input error, not a server error. I had already updated the500to400when initially converting to Typescript.)