Skip hidden file events before target filtering#60
Open
apple-ouyang wants to merge 1 commit into
Open
Conversation
Avoid sending dot-prefixed storage events through the normal target-file filter when internal file synchronisation is disabled. This keeps paths such as .git/objects from reaching later database-backed filters that can emit noisy "not target" logs. Add a regression test for the early skip path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vaultService.isTargetFileWhy
When
syncInternalFilesis disabled, hidden paths are already non-targets. However, storage events for paths such as.git/objects/...still reached later target filtering, which could emit noisy database-backed "not target" logs before being skipped.Verification
vitest run src/lib/src/managers/StorageEventManager.unit.spec.ts --config vitest.config.unit.ts(red before fix, green after fix)npm run test:unitnpx tsc --noEmitnpx eslint src/lib/src/managers/StorageEventManager.ts src/lib/src/managers/StorageEventManager.unit.spec.ts(source file checked; the spec file is ignored by the repository ESLint config and reports a warning only)npm run checkdid not complete in my local environment becausegenerate-types.mjscallsDeno, and that command is not installed here. Please run CI tests.