Make Fast Fetch retry transient interruptions#59
Open
apple-ouyang wants to merge 1 commit into
Open
Conversation
Fast Fetch could fail immediately when the streaming changes request was interrupted by a network change or platform abort. This keeps the persisted checkpoint useful inside the same initialisation run by retrying from the latest saved sequence. It also stops treating external AbortError failures as successful target-sequence completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Fast Fetch retry transient streaming interruptions from the latest persisted checkpoint.
Context
Follow-up issue: vrtmrz/obsidian-livesync#977
Changes
AbortErrors so the retry layer can handle transient network or platform interruptions.Verification
Ran from the top-level plug-in repository:
npm test -- --config vitest.config.unit.ts src/serviceFeatures/redFlag.unit.spec.ts src/lib/src/pouchdb/StreamingFetch.unit.spec.ts src/lib/src/serviceModules/Rebuilder.unit.spec.tsnpm run tsc-checknpx eslint --no-warn-ignored src/serviceFeatures/redFlag.simpleFetch.ts src/serviceFeatures/redFlag.unit.spec.ts src/lib/src/pouchdb/StreamingFetch.ts src/lib/src/pouchdb/StreamingFetch.unit.spec.ts src/lib/src/serviceModules/Rebuilder.ts src/lib/src/serviceModules/Rebuilder.unit.spec.tsnpm run build