Adds file move operation and startup robustness#50
Open
adriy-be wants to merge 6 commits into
Open
Conversation
Author
|
It's a feat for https://github.com/fanselau/obsidian-vault-cli |
Owner
|
Thank you for your PR! This is a minor point, but let me clarify something. Incidentally, as you can see from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes you made :
movemethods acrossDirectFileManipulator,LiveSyncLocalDB, andEntryManager.moveDBEntryByPathinEntryManagerImplsto handle database-level moves, including case-only renames, overwrites, and marking source entries as deleted.moveDBEntryByPathfunctionality.initprocess in atry...catchblock to ensure thereadypromise correctly resolves or rejects, improving startup error handling.api.addLogand a default vault name forapi.getSystemVaultNameduring early startup to prevent potential runtime errors from unassigned API handlers.closemethod, attempting to use acontrolservice'sonUnloadhook before falling back to direct database shutdown.