fix: yield results from _enumerate when metaOnly is true#21
Closed
es617 wants to merge 1 commit into
Closed
Conversation
In `_enumerate`, the `metaOnly` branch used `return` instead of
`return yield*`, causing `enumerateAllNormalDocs({ metaOnly: true })`
to silently produce zero results. The async generator returned the
inner iterator as a value rather than delegating to it.
Author
|
Closing this — the original branch was based on an old commit. Reopened as #22 with the same one-line fix, now based on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DirectFileManipulator._enumerate()silently returns zero results when called withmetaOnly: true.In an
async *generator function, a barereturn <value>doesn't yield anything to the caller — it just sets the generator's return value (whichfor await...ofignores). The current code returns the async iterator fromfindEntries()as a completion value instead of delegating to it.This means
enumerateAllNormalDocs({ metaOnly: true })always produces an empty sequence.Fix
yield*delegates to the inner async generator, forwarding all its values to the caller.