Also check Answers for records#59
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| if (_discovery != null) | ||
| { | ||
| foreach (var profile in _profiles.Keys.ToArray()) | ||
| Unadvertise(profile); | ||
|
|
||
| _discovery.Dispose(); |
There was a problem hiding this comment.
idk what these are, seems like Rider fixed the indentation but I don't see any difference. Maybe I'm blind
There was a problem hiding this comment.
Ok, I force-pushed and this time I edited by hand, this seems to be a git merge commit thing lol
There was a problem hiding this comment.
hiding whitespace hides these, if it's not indentation then it might be git modifying the line endings on account of weird git configuration
There was a problem hiding this comment.
yeah, you probably right. I'm in Linux and this repository probably uses LF only, right?
I have core.autocrlf=input
There was a problem hiding this comment.
$ file vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/ZeroconfTypes.cs
vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/ZeroconfTypes.cs: Unicode text, UTF-8 (with BOM) text, with CRLF line terminators
$ file vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/MeaModDiscovery.cs
vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/MeaModDiscovery.cs: Unicode text, UTF-8 (with BOM) text, with CRLF, LF line terminators
looks like it might not be standardized in the file anyways. Hmm...
There was a problem hiding this comment.
Well, it should be solved in another PR. And probably added inside the .gitattributes
ImUrX
force-pushed
the
fix-record-lookup
branch
from
0e61b4a to
39a34e5
Compare
|
it would be nice to merge this as it will fix VRChat desktop working with SlimeVR OSCQuery's implementation |
|
@momo-the-monster any hope in getting this merged one day? |
momo-the-monster
left a comment
momo-the-monster
left a comment
There was a problem hiding this comment.
Thank you for the ping! Soon™️ is NOW
4 participants
Fixes #58