Repository navigation
fix(web): name Taranity as the site's controller - #84
Conversation
The privacy page named the controller only by role and sent people to open an issue, which GDPR Article 13 does not accept as an identity and which nobody can do while the repository is private. The privacy and accessibility pages now name Taranity and its contact address, privacy@taranity.com. The tests that kept addresses off the page now allow that one address and no other.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
House review of bda5e12, its first house review.
The PR replaces the role-only controller with "Taranity" and the contact "email
privacy@taranity.com" in `CONTROLLER`. That constant feeds the privacy page's website facts and the
accessibility page's contact line. The PR also updates the record of processing and changes two
tests so they accept that one address and no other. The content change is correct and consistent.
The privacy page renders "The controller of this website is Taranity. To reach them, email
privacy@taranity.com." The new regex does not swallow the sentence's closing full stop, and none of
the repo's text scanners would flag the address. One test gap remains against the issue's third
acceptance criterion.
1 finding: 1 minor. It is a thread on this pull request, marked resolved once it is handled:
1. minor, test-gap packages/web/src/site/privacy.test.ts:177 The 'no other address' guard only checks the controller sentences, not either page, so issue #83's third criterion is not enforced., a thread on its line
The tests that kept stray addresses off the site read only the controller sentences, so an address typed into the privacy page's own markup, a list beside those sentences or the accessibility page would still have shipped with everything green. The pattern they used also counted only email-shaped text, so ops@localhost or a non-ASCII domain slipped past. The built checks now read the privacy and accessibility pages whole, labels, shown metas and link targets included, and fail any @ that is not privacy@taranity.com. The address lives in one constant that the page sentence and the check both use, and the two unit tests count every @ again, as they did before the address went in.
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
House review of f837b97, a re-review after bda5e12, review 2 of 3.
The PR names Taranity as the site's controller, with privacy@taranity.com as the one contact
address, on the privacy and accessibility pages and in the record of processing. The new commits add
a `contact-address` built check (rules.ts) that treats every @ on those two pages as an address, and
they widen the unit tests to cover every statement list. Earlier finding 1 is fixed. The new check
reads all the text on both built pages, including labels, shown metas and every href. So addresses
in the pages' own markup, in the PRIVACY_REQUIRED/accessibility statements, in mailto or cc targets,
and in shapes without a dot (`ops@localhost`) or with a non-ASCII domain are now caught. I checked
the real pages for false positives and found none. Neither page renders an @ in its markup. The
forget command shown is only `aws lambda invoke`, and the `jane@example.org` payload line is not
rendered. Block elements are separated with spaces when page text is read, so the address cannot
fuse with the next list item. The planted test fixtures carry only the controller address. No new
defects found.
No findings.
Closes #83.
The privacy page only said the controller was "the developer who built this hackathon entry" and pointed people at a GitHub issue. That isn't an identity under GDPR, and nobody can open an issue while the repo is private.
I changed the privacy and accessibility pages to name Taranity, my business behind the site's domain, with privacy@taranity.com as the contact, and updated the record of processing to match. The two tests that kept every address off the pages now allow that one address and still fail on any other.
Tests pass, and both built pages show the new line.
After merge: the site needs a redeploy for the pages to change.