Skip to content

fix(web): name the visitor IP's transfer and retention - #82

Merged
voyagi merged 1 commit into
mainfrom
fix/privacy-transfer-ip
Oct 25, 2026
Merged

voyagi merged 1 commit into
mainfrom
fix/privacy-transfer-ip

Conversation

@voyagi

@voyagi voyagi commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Closes #81.

The privacy page told visitors that Cloudflare gets their IP address, but not that the page can be served from outside the EEA or how long the address is kept.

I added two sentences to the website section, both taken from Cloudflare's Customer DPA (version 6.4): a transfer runs under the EU Standard Contractual Clauses, or the EU-U.S. Data Privacy Framework for the United States (clauses 6.2(a) and 6.4), and Cloudflare keeps the data only while its service needs it, at the latest until the agreement ends (Annex 1, section B). Its privacy policy gives no fixed number of days, so the page gives that rule instead. The site itself turns on no request log. I also brought the record of processing in line with the same clauses.

Tests pass, and the build check now fails on a page that drops either sentence.

After merge: the site needs a redeploy for the page to change.

The privacy page said Cloudflare receives the visitor's IP address but not
that its network can serve a page from outside the EEA, what covers that
transfer, or how long the address is kept (GDPR Article 13(1)(f) and
13(2)(a)). Both sentences follow Cloudflare's Customer DPA version 6.4,
read 2026-10-25: clauses 6.2(a) and 6.4 for the transfer, Annex 1 section
B for the retention rule. The record of processing now says the same.
@voyagi voyagi added the risk-lane Needs two different reviewers label Oct 25, 2026
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • review-ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 3f832383-549f-47ed-95a2-b807b60f3be8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-25T07:12:34.013568Z 549434b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@voyagi

voyagi commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@voyagi-house-review voyagi-house-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

House review of 549434b, its first house review.

The PR adds two website facts to WEBSITE_FACTS: one on Cloudflare's transfer outside the EEA and its
safeguard, and one on the visitor IP's retention rule. It renders them in the website list item of
the privacy page and adds both IDs to the parameterised websiteFactsRule test, so the build check
now fails when either sentence is missing. It also updates the record of processing to match. I
traced the full path: content.ts feeds gates.ts `shown(WEBSITE_FACTS, region)`, which
statementFindings checks with a substring match. The page's `website()` lookup fails if an ID is
missing, and the test fixture builds from the same list. Nothing breaks, the other page-wide rules
(model-role claims, replay word cap) don't touch this text, and the "no request log" claim matches
wrangler.jsonc, which holds only the assets block. I could not check the cited Cloudflare DPA
clauses from the repository, so the legal wording itself is unverified.

No findings.

@voyagi
voyagi merged commit ec11399 into main Oct 25, 2026
4 of 5 checks passed
@voyagi
voyagi deleted the fix/privacy-transfer-ip branch October 25, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-lane Needs two different reviewers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy page doesn't say where the visitor IP goes or how long it's kept

1 participant