Repository navigation
feat(web): add the link preview image, the favicon set and the README card - #74
Conversation
Every page now names a 1200x630 link preview (og:image with its type, size and alt text, twitter:card summary_large_image) and three icons: favicon.ico (16, 32, 48 px, sizes="32x32" so Chrome keeps the SVG), favicon.svg (the top bar's sail mark, ropes light in dark mode) and a 180 px apple-touch-icon on white. The 404 page gets them too, still without canonical or og:url. The preview is the card's scene in a 1.91:1 frame with room under the board, so a 2:1 crop cuts nothing. The page metadata rule now requires og:image and og:image:alt, and tests read the shipped files' real sizes.
The 1600x900 card (the name, the claim and the night board of the live run of 22 October 2026) now sits under the title, with alt text that states the board's facts. docs/card.png joins the tracked-paths list.
DESIGN.md now describes the favicon set (the top bar's sail mark, its dark-mode ropes, the .ico sizes and the home-screen icon) and the 1200x630 link preview frame with its crop margin.
|
@codex review |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
House review of a59631b, its first house review.
The PR adds og:image metadata with summary_large_image, three icon links on every page including the
404 page, the favicon files, a build-check requirement for og:image and og:image:alt, and the README
card. The TypeScript changes are consistent and the tests cover them. One real risk: `favicon.svg`
colours its ropes, in both light and dark mode, only through an inline `<style>` element, and the
site's own `_headers` sends `default-src 'self'` on every file. The repo's own rule comments say
that policy blocks a style element.
1 finding: 1 minor. It is a thread on this pull request, marked resolved once it is handled:
1. minor, reliability packages/web/public/favicon.svg:1 The favicon ropes depend on an inline <style> element, which the site's CSP (sent on every file, the SVG included) can block, leaving the ropes with no stroke, a thread on its line
Not reviewed
docs/card.png (binary)packages/web/public/apple-touch-icon.png (binary)packages/web/public/favicon.ico (binary)packages/web/public/og-image.png (binary)
The site's Content-Security-Policy (default-src 'self') is sent with the SVG too, and a browser that applies it there drops the inline style, so the ropes had no stroke at all. The rope path now carries stroke="#0a1024" itself and the style only switches it to the dark ink in dark mode.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
House review of 1a10017, a re-review after a59631b, review 2 of 3.
The PR adds og:image metadata and twitter:card summary_large_image to every page, adds the favicon
set (ico, svg, apple-touch-icon) to every page head including the 404, makes the page-metadata build
check require og:image and og:image:alt, and puts the card at the top of the README. Earlier finding
1 is fixed. The rope path in favicon.svg now has its own `stroke="#0a1024"` attribute, so the ropes
still draw in ink if a browser blocks the inline style element under the site's CSP. When the style
element is allowed, its rule wins over the stroke attribute, so dark mode still switches the ropes
to the light colour. A new site.test.ts case checks the stroke attribute. The new commits add no
defects, and I found no other critical or major problem in the PR.
No findings.
Not reviewed
docs/card.png (binary)packages/web/public/apple-touch-icon.png (binary)packages/web/public/favicon.ico (binary)packages/web/public/og-image.png (binary)
Closes #73
What changes
https://fothering.taranity.com/og-image.pngwithog:image:type,og:image:width(1200),og:image:height(630) andog:image:alt, andtwitter:cardmoves fromsummarytosummary_large_image. The image is the card's scene in its own 1.91:1 frame: every size as on the 1600x900 card, the board ending 30 px above the foot, so a 2:1 crop cuts nothing.favicon.ico(16, 32 and 48 px, linked withsizes="32x32"so Chrome keeps the SVG),favicon.svg(the top bar's sail mark, ropes switch to the dark ink underprefers-color-scheme: dark) and a 180 pxapple-touch-icon.pngon white. The 404 page carries them too, and still has no canonical orog:url.og:imageandog:image:alton every built page. The planted test pages gained both items, so the existing loop adds a failing case for each.docs/card.png(the 1600x900 card) opens the README under the title, and joinstracked-paths.json.Each PNG carries one plain
Sourcetext chunk saying what it shows and that the board comes from the live run of 22 October 2026.check-artifact-metadata.mjsis clean over all four tracked images.How it was checked
site.test.tsandbuilt-checks.test.ts, 381 tests. Tests read the shipped files' real sizes (the PNG headers, the.icodirectory, the SVG's dark-mode rule).npm run build: the builtindex.htmland404.htmlcarry the fiveog:imageitems,summary_large_imageand the three icon links.npm run test:e2e: PASS, 9 steps over 6 built pages, every request from the page's own origin, no Content Security Policy violation.npm run lintclean, the pre-push suite 3563 passed and 2 skipped.After merge
The live site keeps its old head until the next deploy (
docs/deploy-the-site.md). Platforms cache link previews, so a page shared before the deploy may show the old preview for a while.