Allow the user to prevent the lookup from raising an exception#118
Open
tskirvin wants to merge 5 commits into
Open
Allow the user to prevent the lookup from raising an exception#118tskirvin wants to merge 5 commits into
tskirvin wants to merge 5 commits into
Conversation
This reverts commit 5e5ed91, putting back the option to prevent exceptions from being raised.
Author
|
The static validations stuff - I'm not sure if that's a problem with the test suite in general or in the code I merged in. |
Member
|
CI fails because the ruby code isn't valid anymore, please have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick attempt to merge in #12 into the current module world. It adds a 'raise_exceptions' option to lookup code to fail with an error message rather than failing out of the whole puppet process.
I haven't tested yet. Original comments, from @Magisus: