Skip to content

try using vagrant#50

Draft
evgeni wants to merge 1 commit into
voxpupuli:masterfrom
evgeni:vagrant
Draft

try using vagrant#50
evgeni wants to merge 1 commit into
voxpupuli:masterfrom
evgeni:vagrant

Conversation

@evgeni

@evgeni evgeni commented Jan 22, 2024

Copy link
Copy Markdown
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Comment thread .github/workflows/ci.yml Outdated
uses: evgeni/gha-puppet/.github/workflows/beaker.yml@vagrant
with:
pidfile_workaround: 'false'
beaker_hypervisor: vagrant

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be libvirt?

Suggested change
beaker_hypervisor: vagrant
beaker_hypervisor: vagrant_libvirt

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The Beaker hypervisor is Vagrant. Which hypervisor vagrant then uses is a different beast. ;)

(hypervisors all the way down)

@evgeni evgeni Jan 22, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and I won't go down the rabbithole that libvirt can use different backends, besides qemu, but vagrant-libvirt really only knows about qemu)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's surprising, because I have:

$ env | grep BEAKER
BEAKER_HYPERVISOR=vagrant_libvirt

@evgeni evgeni closed this Jan 22, 2024
@evgeni evgeni reopened this Jan 22, 2024
@evgeni evgeni closed this Jan 22, 2024
@evgeni evgeni reopened this Jan 22, 2024
@kenyon

kenyon commented Jan 22, 2024

Copy link
Copy Markdown
Member

If you can get this working, I think running tests with vagrant VMs instead of docker will help fix tests for https://github.com/voxpupuli/puppet-chrony and https://github.com/voxpupuli/puppet-rsyslog/ and maybe others.

@evgeni

evgeni commented Jan 22, 2024

Copy link
Copy Markdown
Member Author

This PR was mostly a playground for voxpupuli/gha-puppet#49, but yes this can be useful for a couple of modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants