beaker: Set default hypervisor to container_podman & Remove pidfile workaround option#82
Conversation
ekohl
left a comment
There was a problem hiding this comment.
I don't know the exact impact, but I do like this idea. Once we do this we can also drop the pidfile workaround that we have in place. I wonder if https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/beaker.rb should inspect the hypervisor as well and only apply the workaround if it's docker. Or is there a better way?
|
I assume we can just remove the whole pidfile stuff. We only use it on two modules at the moment, and that can be removed: |
|
and cleanup for puppet_metadata: voxpupuli/puppet_metadata#192 |
3900969 to
e3f573e
Compare
|
@ekohl I think it also makes sense to remove the pidfile workaround option from the workflow? We don't use it anywhere and it doesn't provide any value, even on docker. Removing it now means we can safely remove the pidfile parameter from puppet_metadata, without breaking this workflow. |
note: this goes into the new v4 branch, we are currently using v4.