Skip to content

beaker: Set default hypervisor to container_podman & Remove pidfile workaround option#82

Merged
bastelfreak merged 2 commits into
voxpupuli:v4from
bastelfreak:container_podman
Oct 17, 2025
Merged

beaker: Set default hypervisor to container_podman & Remove pidfile workaround option#82
bastelfreak merged 2 commits into
voxpupuli:v4from
bastelfreak:container_podman

Conversation

@bastelfreak

Copy link
Copy Markdown
Member

note: this goes into the new v4 branch, we are currently using v4.

@bastelfreak bastelfreak self-assigned this Oct 16, 2025
@bastelfreak bastelfreak added the enhancement New feature or request label Oct 16, 2025

@ekohl ekohl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the exact impact, but I do like this idea. Once we do this we can also drop the pidfile workaround that we have in place. I wonder if https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/beaker.rb should inspect the hypervisor as well and only apply the workaround if it's docker. Or is there a better way?

@bastelfreak

Copy link
Copy Markdown
Member Author

I assume we can just remove the whole pidfile stuff. We only use it on two modules at the moment, and that can be removed:

@bastelfreak

Copy link
Copy Markdown
Member Author

and cleanup for puppet_metadata: voxpupuli/puppet_metadata#192

@bastelfreak bastelfreak changed the title beaker: Set default hypervisor to container_podman beaker: Set default hypervisor to container_podman & Remove pidfile workaround option Oct 17, 2025
@bastelfreak

Copy link
Copy Markdown
Member Author

@ekohl I think it also makes sense to remove the pidfile workaround option from the workflow? We don't use it anywhere and it doesn't provide any value, even on docker. Removing it now means we can safely remove the pidfile parameter from puppet_metadata, without breaking this workflow.

@ekohl ekohl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay simplification.

@bastelfreak
bastelfreak merged commit 1ca8866 into voxpupuli:v4 Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants