Feat: Add sitemap#87
Open
slimluccii wants to merge 6 commits into
Open
Conversation
Deploying dda-website with
|
| Latest commit: |
f0c0695
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88ea7078.dda-website.pages.dev |
| Branch Preview URL: | https://feat-add-sitemap.dda-website.pages.dev |
sjoerdbeentjes
requested changes
Feb 5, 2025
sjoerdbeentjes
left a comment
sjoerdbeentjes
left a comment
Contributor
There was a problem hiding this comment.
Looks good! One small comment.
| import { datocmsCollection } from '@lib/datocms'; | ||
| import type { APIRoute } from 'astro'; | ||
|
|
||
| export const prerender = true; |
| > | ||
| <url><loc>${site}</loc></url> | ||
| <url><loc>${site}events/</loc></url> | ||
| ${events.map((event) => `<url><loc>${site}events/${event.details.slug}</loc></url>`).join('\n') } |
Contributor
There was a problem hiding this comment.
Can we make this a function like generateUrlTags, since there's some repetition below.
sjoerdbeentjes
force-pushed
the
main
branch
2 times, most recently
from
c0db51f to
3a82666
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How to test
/sitemap.xmlChecklist
I have made updated relevant documentation files (in project README, docs/, etc)I have added a decision log entry if the change affects the architecture or changes a significant technology