Feat/ai internship filled cohort#117
Merged
Merged
Conversation
Deploying dda-website with
|
| Latest commit: |
0f94ea6
|
| Status: | ⚡️ Build in progress... |
sjoerdbeentjes
force-pushed
the
feat/ai-internship-filled-cohort
branch
from
3141064 to
fed6f4d
Compare
- Exclude config/datocms/migrations from TypeScript type checking to fix 25 type errors caused by version mismatches with DatoCMS client types - Update prep:cloudflare-env script to populate .dev.vars with SESSION= binding to prevent Vitest errors with Cloudflare adapter
SCW_PROJECT_ID and TURNSTILE_SITE_KEY are public env schema fields without defaults, so Astro treats empty strings as missing during build validation. Use the official Turnstile dummy site key.
The hoisted vite was still 5.4.21 while Astro 5.18 ships vite 6, so vitest ran Astro's vite plugins against a vite 5 plugin container that lacks this.environment, crashing every test file. Pin vite 6 and upgrade vitest to v3 (which also fixes the 'test' property type error in vitest.config.ts). html-validate moves to v11 to satisfy vitest 3 peer deps; its new unique-landmark rule is disabled to keep parity with the v8 ruleset.
Astro validates public env vars when modules import astro:env (unit tests) and secret vars during prerendering (build), so every job needs non-empty values for the new SCW and Turnstile variables.
html-validate 11 requires Node 22+ (fs.globSync); v10 supports Node 20 and still satisfies the vitest 3 peer dependency.
slimluccii
reviewed
Jun 10, 2026
|
|
||
| import './Textarea.css'; | ||
|
|
||
| type Props = { |
Contributor
There was a problem hiding this comment.
Nice to have maybe. Do something like ComponentProps<HeadlessTextarea> & ... and spread the props.
slimluccii
approved these changes
Jun 10, 2026
sjoerdbeentjes
force-pushed
the
feat/ai-internship-filled-cohort
branch
from
5e557b8 to
16f7e17
Compare
sjoerdbeentjes
force-pushed
the
feat/ai-internship-filled-cohort
branch
from
24c49e5 to
0f94ea6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Filled internship positions (
position_filled)position_filledon theai_internshipmodel (defaultfalse), set by agencies in their own profile.positionFilled: { eq: false }.Cohorts (
cohort) — data model only🎓 Cohortmodel (name+start_date).cohortfield onai_internship(optional).cohortfilter can be added later inAiInternshipListlike track/province/language.Application form improvements
Textareaform component.message) to the application form;linkedinis now required.messagethrough to the email templates; agency subject line is now templated to include the vacancy title viafillTemplate.1780963200_aiInternshipFormImprovementsadds theopen_questiontranslation and updates the agency + confirmation email templates (vacancy name in subject/body, open-question answer in body).Migrations / environment
position_filledfield,cohortmodel + link, form/email improvements.datocmsEnvironmenttorelease-ai-internship-filled.Associated issue
How to test
Checklist
docs/ai-internships-followup.md, incl. DatoCMS deploy runbook)