Run Codegen Check for all pull requests#411
Conversation
Signed-off-by: Safiya <147792763+safiya2610@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes unused dependency entries for golang.org/x/oauth2 v0.36.0 from the go.sum file. I have no feedback to provide as there are no review comments or issues identified.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR updates the CI “Codegen Check” workflow so make gen-check runs for every pull request targeting main and release-*, instead of being skipped via path-based filtering. This helps catch generated-code and dependency consistency issues (e.g., go.mod / go.sum changes) immediately.
Changes:
- Removed
dorny/paths-filtergating from the Codegen Check workflow. - Made Go setup and
make gen-checkexecute unconditionally for PRs intomainandrelease-*. - Updated
go.sumto drop now-unneededgolang.org/x/oauth2 v0.36.0entries.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
go.sum |
Removes stale module checksum entries so module state matches actual requirements. |
.github/workflows/codegen-check.yml |
Ensures make gen-check runs on every PR to main / release-* by removing path-based filtering. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
===========================================
+ Coverage 47.57% 58.66% +11.09%
===========================================
Files 30 37 +7
Lines 2819 3491 +672
===========================================
+ Hits 1341 2048 +707
+ Misses 1338 1234 -104
- Partials 140 209 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@zhzhuang-zju Please review this PR. |
|
/cc @RainbowMango |
This PR removes path-based filtering from the Codegen Check workflow so that make gen-check runs for every pull request.
Motivation
Previously, Codegen Check could be skipped when changes did not match the configured path filters. As a result, changes to files such as go.mod and go.sum could bypass the workflow, allowing code generation inconsistencies to remain undetected until a later pull request.
Running the workflow unconditionally ensures that generated code and dependency-related inconsistencies are detected immediately, improving CI reliability.
Changes
Removed path-based filtering from the Codegen Check workflow.
Configured make gen-check to run for every pull request targeting main and release-*.
Fixes #401