workloadmanager: honor default code interpreter auth mode#398
Conversation
Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the workload builder to inject and validate the public key for all authentication modes except when authMode is explicitly set to none (previously, this was only done when authMode was set to picod). It also adds corresponding unit tests to verify this behavior, including a test for empty/default authentication modes. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Hey @RainbowMango @hezhangjian Pls take a look, Found this while checking the CodeInterpreter auth paths. Warm-pool already treats empty authMode as default PicoD auth, but the non-warm builder only handled explicit |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
===========================================
+ Coverage 47.57% 58.57% +11.00%
===========================================
Files 30 37 +7
Lines 2819 3491 +672
===========================================
+ Hits 1341 2045 +704
+ Misses 1338 1237 -101
- Partials 140 209 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/lgtm |
/kind bug
What this PR does / why we need it:
Keeps CodeInterpreter auth handling consistent between warm-pool and non-warm sandbox creation.
The non-warm path only treated explicit
picodas PicoD auth. This makes the default/empty value behave the same way, matching the warm-pool path: anything exceptnonegets the PicoD public key handling.Which issue(s) this PR fixes:
Fixes #397
Special notes for your reviewer:
Added coverage for empty/default authMode in env injection and missing-key handling.
Does this PR introduce a user-facing change?: