test(env): snapshot list-remote json markers#1970
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 746e940403
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "vp env install lts # Install an LTS Node.js version locally", | ||
| "vp env default lts # Set it as the global default (stored as the `lts` alias)", | ||
| "vp env list-remote --lts --json | node -e \"const {versions}=JSON.parse(require('fs').readFileSync(0,'utf8')); console.log('installed marked:', versions.some(v=>v.installed)); console.log('current marked:', versions.some(v=>v.current)); console.log('default marked:', versions.some(v=>v.default));\" # installed/current/default flags should all resolve, including the `lts` default alias" | ||
| "vp env list-remote --lts --json # installed/current/default flags should all resolve, including the `lts` default alias" |
There was a problem hiding this comment.
When this snap test runs on a machine whose ~/.vite-plus contains a different set of installed Node versions, or after the remote Node distribution index gains another LTS release, this command will rewrite snap.txt even though the CLI is correct. vp env list-remote fetches the remote version index and annotates every row from local VP_HOME state (installed/current/default), while the snap runner treats the whole stdout as the expected snapshot; the previous pipe asserted only the marker predicates and avoided depending on the full remote/local list.
Useful? React with 👍 / 👎.
|
I tested this before merging, and it caused unstable output. Also, there was too much content. So I'll stick to using scripts for assertion verification. |
2 participants
Description
Follow-up to #1907. Preserve the raw
vp env list-remote --lts --jsonoutput in the global snap test so the JSON marker fields stay covered.Testing
pnpm -F vite-plus snap-test-global command-env-list-remote