Skip to content

fix(pm): allow cache flags without separator#1931

Closed
jong-kyung wants to merge 4 commits into
voidzero-dev:mainfrom
jong-kyung:fix/pm-cache-pass-through-flags
Closed

fix(pm): allow cache flags without separator#1931
jong-kyung wants to merge 4 commits into
voidzero-dev:mainfrom
jong-kyung:fix/pm-cache-pass-through-flags

Conversation

@jong-kyung

Copy link
Copy Markdown
Collaborator

Summary

Improve vp pm cache pass-through argument parsing so cache commands can accept package-manager flags without
requiring a -- separator, such as vp pm cache clean --force.

@netlify

netlify Bot commented Jun 24, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit c4c1f35
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a3bda0e865fc90007a42a9d

@jong-kyung jong-kyung self-assigned this Jun 24, 2026
@jong-kyung jong-kyung force-pushed the fix/pm-cache-pass-through-flags branch from acdb746 to b189c36 Compare June 24, 2026 03:08
@jong-kyung jong-kyung marked this pull request as ready for review June 24, 2026 03:18
@jong-kyung jong-kyung requested a review from fengmk2 June 24, 2026 03:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b189c36878

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/snap-tests-global/command-cache-npm10/steps.json Outdated
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83f866f333

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/snap-tests-global/command-cache-yarn4/steps.json Outdated
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: e04850e94e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2

fengmk2 commented Jun 24, 2026

Copy link
Copy Markdown
Member

Why do we need to change this? The current requirement to use -- to pass parameters not managed by vite+ is intentional. Similar designs can be seen in other subcommands of vp pm. This is designed to avoid adding parameters later. If -- were removed, any differentiated parameters would confuse users.

@jong-kyung

Copy link
Copy Markdown
Collaborator Author

Why do we need to change this? The current requirement to use -- to pass parameters not managed by vite+ is intentional. Similar designs can be seen in other subcommands of vp pm. This is designed to avoid adding parameters later. If -- were removed, any differentiated parameters would confuse users.

Thanks, that makes sense. I opened this because docs/guide/install.md currently shows vp pm cache clean --force, so I assumed that was the intended UX.

If requiring -- for package-manager-specific flags is intentional, I agree this PR should not change the parser behavior. I will update the docs to use vp pm cache clean -- --force instead.

@jong-kyung

Copy link
Copy Markdown
Collaborator Author

I’ll close this PR and update docs/guide/install.md instead. 🙇‍♂️

@jong-kyung jong-kyung closed this Jun 24, 2026
@jong-kyung jong-kyung deleted the fix/pm-cache-pass-through-flags branch June 24, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants