Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions crates/vite_setup/src/registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,24 @@ pub struct PackageVersionMetadata {
pub struct DistInfo {
pub tarball: String,
pub integrity: String,
#[serde(default)]
pub attestations: Option<DistAttestations>,
}

/// npm attestation metadata from `dist.attestations`.
#[derive(Debug, Deserialize)]
pub struct DistAttestations {
#[serde(default)]
pub provenance: Option<serde_json::Value>,
}

impl DistInfo {
fn has_provenance(&self) -> bool {
self.attestations
.as_ref()
.and_then(|attestations| attestations.provenance.as_ref())
.is_some()
}
}

/// Resolved version info with URLs and integrity for the platform package.
Expand Down Expand Up @@ -86,6 +104,17 @@ pub async fn resolve_platform_package(
)
})?;

if !cli_meta.dist.has_provenance() {
return Err(Error::Setup(
format!(
"Refusing to install {cli_package_name}@{} because its npm package metadata \
does not include provenance attestation.",
cli_meta.version
)
.into(),
));
}

Ok(ResolvedVersion {
version: version.to_owned(),
platform_tarball_url: cli_meta.dist.tarball,
Expand Down Expand Up @@ -118,6 +147,43 @@ mod tests {
assert_eq!(name, "@voidzero-dev/vite-plus-cli-darwin-arm64");
}

#[test]
fn test_dist_info_detects_provenance() {
let meta: PackageVersionMetadata = serde_json::from_value(serde_json::json!({
"version": "0.2.0",
"dist": {
"tarball": "https://registry.npmjs.org/package.tgz",
"integrity": "sha512-test",
"attestations": {
"url": "https://registry.npmjs.org/-/npm/v1/attestations/pkg@0.2.0",
"provenance": {
"predicateType": "https://slsa.dev/provenance/v1"
}
}
}
}))
.unwrap();

assert!(meta.dist.has_provenance());
}

#[test]
fn test_dist_info_rejects_missing_provenance() {
let meta: PackageVersionMetadata = serde_json::from_value(serde_json::json!({
"version": "0.2.0",
"dist": {
"tarball": "https://registry.npmjs.org/package.tgz",
"integrity": "sha512-test",
"attestations": {
"url": "https://registry.npmjs.org/-/npm/v1/attestations/pkg@0.2.0"
}
}
}))
.unwrap();

assert!(!meta.dist.has_provenance());
}

#[test]
fn test_all_platform_suffixes_match_published_cli_packages() {
// These are the actual published CLI package suffixes
Expand Down
43 changes: 43 additions & 0 deletions packages/cli/install.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,48 @@ function Get-VersionFromMetadata {
return $metadata.version
}

function Assert-PlatformPackageProvenance {
param(
[string]$PackageName,
[string]$Version
)

$encodedPackageName = [System.Uri]::EscapeDataString($PackageName)
$metadataUrl = "$NpmRegistry/$encodedPackageName/$Version"
try {
$metadata = Invoke-RestMethod -Uri $metadataUrl -Headers @{ Accept = "application/json" }
Comment thread
wyf027 marked this conversation as resolved.
} catch {
$errorMsg = $_.ErrorDetails.Message
if ($errorMsg) {
try {
$errorJson = $errorMsg | ConvertFrom-Json
if ($errorJson.error) {
Write-Error-Exit "Failed to fetch CLI package metadata '${PackageName}@${Version}': $($errorJson.error)`n URL: $metadataUrl"
}
} catch {
# JSON parsing failed, fall through to generic error
}
}
Write-Error-Exit "Failed to fetch CLI package metadata from: $metadataUrl`nError: $_"
}

if ($metadata -is [string]) {
try {
$metadata = $metadata | ConvertFrom-Json
} catch {
Write-Error-Exit "Failed to parse CLI package metadata '${PackageName}@${Version}'`n URL: $metadataUrl"
}
}

if ($metadata.error) {
Write-Error-Exit "Failed to fetch CLI package metadata '${PackageName}@${Version}': $($metadata.error)`n URL: $metadataUrl"
}

if (-not $metadata.dist -or -not $metadata.dist.attestations -or -not $metadata.dist.attestations.provenance) {
Write-Error-Exit "Refusing to install ${PackageName}@${Version} because its npm package metadata does not include provenance attestation."
}
}

function Get-PlatformSuffix {
param([string]$Platform)
# Windows needs -msvc suffix, other platforms map directly
Expand Down Expand Up @@ -516,6 +558,7 @@ function Main {
$platformUrl = "$PkgPrNewBase/@voidzero-dev/vite-plus-cli-$platformSuffix@$PrVersion"
} else {
$packageName = "@voidzero-dev/vite-plus-cli-$platformSuffix"
Assert-PlatformPackageProvenance -PackageName $packageName -Version $ViteVersion
$platformUrl = "$NpmRegistry/$packageName/-/vite-plus-cli-$platformSuffix-$ViteVersion.tgz"
}

Expand Down
58 changes: 58 additions & 0 deletions packages/cli/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,63 @@ get_version_from_metadata() {
fi
}

verify_platform_package_provenance() {
local package_name="$1"
local package_version="$2"
local encoded_package_name="${package_name/\//%2F}"
local metadata_url="${NPM_REGISTRY}/${encoded_package_name}/${package_version}"
local metadata

metadata=$(curl_with_error_handling -s "$metadata_url")
if [ -z "$metadata" ]; then
error "Failed to fetch CLI package metadata from: $metadata_url"
fi

if echo "$metadata" | grep -q '"error"'; then
local error_msg
error_msg=$(echo "$metadata" | grep -o '"error" *: *"[^"]*"' | cut -d'"' -f4)
error "Failed to fetch CLI package metadata '${package_name}@${package_version}': ${error_msg:-unknown error}\n URL: $metadata_url"
fi

if ! printf '%s' "$metadata" | awk '
BEGIN { depth = 0; in_str = 0; esc = 0; in_dist = 0; in_attestations = 0; found = 0 }
{
for (i = 1; i <= length($0); i++) {
c = substr($0, i, 1)
if (in_str) {
if (esc) { esc = 0 }
else if (c == "\\") { esc = 1 }
else if (c == "\"") { in_str = 0; last_string = token }
else { token = token c }
continue
}
if (c == "\"") { in_str = 1; token = ""; continue }
if (c == ":" && last_string != "") {
if (!in_dist && last_string == "dist") { expect_object = "dist" }
else if (in_dist && last_string == "attestations") { expect_object = "attestations" }
else if (in_attestations && last_string == "provenance") { found = 1 }
last_string = ""
continue
}
if (c == "{") {
depth++
if (expect_object == "dist") { in_dist = 1; dist_depth = depth; expect_object = "" }
else if (expect_object == "attestations") { in_attestations = 1; attestations_depth = depth; expect_object = "" }
continue
}
if (c == "}") {
if (in_attestations && depth == attestations_depth) { in_attestations = 0 }
if (in_dist && depth == dist_depth) { in_dist = 0 }
depth--
}
}
}
END { exit found ? 0 : 1 }
'; then
error "Refusing to install ${package_name}@${package_version} because its npm package metadata does not include provenance attestation."
fi
}

# Get platform suffix for CLI package download
# Sets PLATFORM_SUFFIX global variable
# Platform format from detect_platform(): darwin-arm64, darwin-x64, linux-x64-gnu, linux-arm64-gnu, win32-x64, etc.
Expand Down Expand Up @@ -921,6 +978,7 @@ main() {
platform_url="${PKG_PR_NEW_BASE}/@voidzero-dev/vite-plus-cli-${PLATFORM_SUFFIX}@${PR_VERSION}"
else
local package_name="@voidzero-dev/vite-plus-cli-${PLATFORM_SUFFIX}"
verify_platform_package_provenance "$package_name" "$VP_VERSION"
platform_url="${NPM_REGISTRY}/${package_name}/-/vite-plus-cli-${PLATFORM_SUFFIX}-${VP_VERSION}.tgz"
fi

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@
"test": "vitest run"
},
"dependencies": {
"@napi-rs/cli": "catalog:",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

"@oxc-project/types": "catalog:",
"@oxlint/plugins": "catalog:",
"@vitest/browser": "catalog:",
Expand All @@ -379,7 +380,6 @@
"vitest": "catalog:"
},
"devDependencies": {
"@napi-rs/cli": "catalog:",
"@nkzw/safe-word-list": "catalog:",
"@oxc-node/core": "catalog:",
"@types/cross-spawn": "catalog:",
Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading