Skip to content

[CI] Bump transformers test pin from 5.5.3 to 5.9.0#43666

Closed
lucianommartins wants to merge 4 commits into
vllm-project:mainfrom
lucianommartins:lucianommartins/ci-tests
Closed

[CI] Bump transformers test pin from 5.5.3 to 5.9.0#43666
lucianommartins wants to merge 4 commits into
vllm-project:mainfrom
lucianommartins:lucianommartins/ci-tests

Conversation

@lucianommartins

Copy link
Copy Markdown
Contributor

Purpose

Bump the transformers test dependency from 5.5.3 to 5.8.0 to unblock CI for Gemma4 architectures that depend on modules introduced in transformers 5.8.0.

Without this bump, any CI job that imports these modules fails with ModuleNotFoundError at model init.

Test Plan

  • Verified that all Gemma4 model variants load and pass end-to-end generation tests with transformers==5.8.0.
  • Verified that existing Gemma4 tower-based tests (Gemma4ForConditionalGeneration) remain unaffected.
  • Checked that no other model in the test registry has an upper-bound constraint that conflicts with 5.8.0.

Test Result

  • Gemma4 E2B (text, image, multi-image, audio, function calling, thinking)
  • Gemma4 26B MoE (text, image, multi-image, function calling, thinking)
  • MTP with assistant drafts: verified on all variants

Files Changed

  • requirements/test/cuda.in — source pin bump
  • requirements/test/rocm.in — source pin bump
  • requirements/test/cuda.txt — lockfile updated via sed
  • requirements/test/rocm.txt — lockfile updated via sed
  • requirements/test/nightly-torch.txt — lockfile updated via sed
  • requirements/test/xpu.txt — lockfile updated via sed

- Gemma4 MTP assistant (Gemma4AssistantForCausalLM) requires
  >= 5.8.0 for the gemma4_assistant module
- Updated both .in source files (cuda.in, rocm.in) and all four
  .txt lockfiles (cuda, rocm, nightly-torch, xpu)
- Lockfiles updated via sed (not uv pip compile) due to private
  registry deps; CI will regenerate if needed

Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the transformers package version from 5.5.3 to 5.8.0 across several test requirement and lock files. The reviewer pointed out that updating the test requirements without also updating the constraints in requirements/common.txt will cause dependency resolution conflicts. Additionally, the reviewer noted that manually updating the lockfiles instead of using uv pip compile is error-prone and bypasses proper dependency resolution.

Comment thread requirements/test/cuda.in Outdated
Comment thread requirements/test/cuda.txt Outdated
@NickLucche NickLucche added the ready-run-all-tests Trigger CI with all tests for wide-ranging PRs label May 26, 2026
@noooop noooop requested a review from hmellor May 29, 2026 05:54
Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>
…quest

Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>
@mergify

mergify Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

Hi @lucianommartins, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

… format tokenizer fallback code

Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>
@lucianommartins lucianommartins force-pushed the lucianommartins/ci-tests branch from 3bd3c91 to 7ca6ac2 Compare June 1, 2026 14:13
@mergify mergify Bot added the multi-modality Related to multi-modality (#4194) label Jun 1, 2026
@lucianommartins lucianommartins changed the title [CI] Bump transformers test pin from 5.5.3 to 5.8.0 [CI] Bump transformers test pin from 5.5.3 to 5.9.0 Jun 1, 2026
@hmellor

hmellor commented Jun 5, 2026

Copy link
Copy Markdown
Member

I'm going to close this as a duplicate of #41359 now that I am actively working on it again. If any Transformers side changes are required I will be able to get them through faster.

@hmellor hmellor closed this Jun 5, 2026
@github-project-automation github-project-automation Bot moved this to Done in NVIDIA Jun 5, 2026
@lucianommartins lucianommartins deleted the lucianommartins/ci-tests branch June 5, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build multi-modality Related to multi-modality (#4194) nvidia ready-run-all-tests Trigger CI with all tests for wide-ranging PRs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants