[CI] Bump transformers test pin from 5.5.3 to 5.9.0#43666
[CI] Bump transformers test pin from 5.5.3 to 5.9.0#43666lucianommartins wants to merge 4 commits into
Conversation
- Gemma4 MTP assistant (Gemma4AssistantForCausalLM) requires >= 5.8.0 for the gemma4_assistant module - Updated both .in source files (cuda.in, rocm.in) and all four .txt lockfiles (cuda, rocm, nightly-torch, xpu) - Lockfiles updated via sed (not uv pip compile) due to private registry deps; CI will regenerate if needed Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request updates the transformers package version from 5.5.3 to 5.8.0 across several test requirement and lock files. The reviewer pointed out that updating the test requirements without also updating the constraints in requirements/common.txt will cause dependency resolution conflicts. Additionally, the reviewer noted that manually updating the lockfiles instead of using uv pip compile is error-prone and bypasses proper dependency resolution.
Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>
d64874e to
c779cf2
Compare
…quest Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>
|
Hi @lucianommartins, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
… format tokenizer fallback code Signed-off-by: Luciano Martins <lucianommartins@users.noreply.github.com>
3bd3c91 to
7ca6ac2
Compare
|
I'm going to close this as a duplicate of #41359 now that I am actively working on it again. If any Transformers side changes are required I will be able to get them through faster. |
Purpose
Bump the
transformerstest dependency from5.5.3to5.8.0to unblock CI for Gemma4 architectures that depend on modules introduced intransformers 5.8.0.Without this bump, any CI job that imports these modules fails with
ModuleNotFoundErrorat model init.Test Plan
transformers==5.8.0.Gemma4ForConditionalGeneration) remain unaffected.5.8.0.Test Result
Files Changed
requirements/test/cuda.in— source pin bumprequirements/test/rocm.in— source pin bumprequirements/test/cuda.txt— lockfile updated via sedrequirements/test/rocm.txt— lockfile updated via sedrequirements/test/nightly-torch.txt— lockfile updated via sedrequirements/test/xpu.txt— lockfile updated via sed