[NPU]: support use-rollout-routing-replay#292
Conversation
Documentation build overview
8 files changed ·
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new training script run-qwen3-30B-A3B-npu-use-routing-replay.sh for running Qwen3-30B-A3B training on NPUs. Feedback on the script highlights two main issues: first, there are duplicate arguments (--use-dynamic-batch-size and --max-tokens-per-gpu) with conflicting values (8192 vs 20480) that need to be cleaned up; second, a hardcoded user directory path is used for the prompt dataset, which should be replaced with a configurable environment variable to improve portability.
| --use-dynamic-batch-size \ | ||
| --max-tokens-per-gpu 8192 \ |
There was a problem hiding this comment.
The arguments --use-dynamic-batch-size and --max-tokens-per-gpu are duplicated in this script (see lines 90-91). Additionally, --max-tokens-per-gpu is specified with conflicting values (8192 vs 20480). Please remove the duplicate entries and keep only the correct configuration (likely 20480 to match the max model length of 20k).
| \ | ||
| --hf-checkpoint /home/data/Qwen3-30B-A3B/ \ | ||
| \ | ||
| --prompt-data /home/w00893744/dataset/dapo-math-17k/dapo-math-17k.jsonl \ |
There was a problem hiding this comment.
The path /home/w00893744/dataset/dapo-math-17k/dapo-math-17k.jsonl contains a hardcoded user directory (w00893744), which prevents the script from being portable across different environments or users. Consider using a configurable environment variable with a fallback default.
| --prompt-data /home/w00893744/dataset/dapo-math-17k/dapo-math-17k.jsonl \ | |
| --prompt-data "${PROMPT_DATA:-/home/data/dapo-math-17k/dapo-math-17k.jsonl}" \ |
|
I'd suggest putting the sh script in #270, and also using the ray submit submission format. 
|
2 participants
No description provided.