Add release image BuildKit cache support#394
Draft
khluu wants to merge 1 commit into
Draft
Conversation
Signed-off-by: vLLM CI <ci@vllm.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds infra-side support for cached CUDA release image builds while keeping the vLLM release pipeline change small.
Changes:
CACHE_FROM_BASE_BRANCHindocker/ci.hcl, keepingCACHE_FROM_BASEas a compatibility alias.vllm-release-cacherepository with the existing 14-day cache lifecycle.Why
The CUDA release image jobs currently build with raw
docker buildcommands and do not import/export the registry BuildKit cache used by CI image builds. This gives release builds cold-cache behavior even though they share expensive layers with CI builds.This PR intentionally only creates the infra target for a release cache. The vLLM-side release pipeline can then add direct BuildKit registry cache flags to the existing
docker buildcommands without converting the release matrix to Bake.The release cache is separate from
vllm-ci-test-cacheandvllm-ci-postmerge-cacheso release-specific variants do not churn CI cache refs.Consumer Contract
CUDA release image jobs should use refs like:
Suggested initial variant tags:
Use direct BuildKit flags on the existing
docker buildrelease commands, for example:The vLLM-side change can also add extra
--cache-fromflags for the existing CI fallback refs if desired, but release jobs should only write release-specific layers tovllm-release-cache.Validation
git diff --check origin/main...HEADNot run locally because this devbox does not have
terraform,docker,tofu, orhclfmtinstalled:terraform fmt -check terraform/aws/ecr.tf terraform/aws/iam.tfdocker buildx bake --print test-ci