[CI] Fetch latest main before computing merge-base to fix stale origin/main on workspaces#390
Open
zxd1997066 wants to merge 1 commit into
Open
[CI] Fetch latest main before computing merge-base to fix stale origin/main on workspaces#390zxd1997066 wants to merge 1 commit into
zxd1997066 wants to merge 1 commit into
Conversation
zxd1997066
force-pushed
the
xiangdong/fetch
branch
from
6466c50 to
8bcc950
Compare
Contributor
|
@khluu Could you please review? |
Contributor
|
@zxd1997066 I would like to use this PR to fix it which only impact intel-CI. Please close your PR. |
Signed-off-by: zengxian <xiangdong.zeng@intel.com>
Author
|
Reopening, as it seems the pipeline generator v2 path still needs this change. |
zxd1997066
force-pushed
the
xiangdong/fetch
branch
from
8bcc950 to
e6a1f64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Buildkite agents with workspace reuse,
origin/maincan become stale if the local git stateis not updated between builds. This causes
git merge-base origin/main HEADto compute anincorrect merge base, leading to:
Solution
Fetch latest main before computing merge-base, ensuring accurate diff and test selection