fix(buildkite): use secure temp file in kickoff-benchmark.sh#388
Open
jcc-google wants to merge 2 commits into
Open
fix(buildkite): use secure temp file in kickoff-benchmark.sh#388jcc-google wants to merge 2 commits into
jcc-google wants to merge 2 commits into
Conversation
Use 'mktemp' to create a secure, unpredictable temporary file in /tmp for merging YAML configurations, instead of writing to a static path 'temp.yaml' in the untrusted checkout directory. This prevents arbitrary file overwrite attacks via malicious symlinks. Signed-off-by: Jincheng Chen <chenjincheng@google.com> BUG=b/510375914 TAG=agy CONV=f5118c4a-3577-4dc6-a4b6-1f2abb990935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use 'mktemp' to create a secure, unpredictable temporary file in /tmp for merging YAML configurations, instead of writing to a static path 'temp.yaml' in the untrusted checkout directory. This prevents arbitrary file overwrite attacks via malicious symlinks.
BUG=b/510375914
TAG=agy
CONV=f5118c4a-3577-4dc6-a4b6-1f2abb990935