Soft-fail Intel CPU queue and CPU-* jobs#373
Open
khluu wants to merge 1 commit into
Open
Conversation
Mark any generated Buildkite step as soft_fail when it runs on the intel-cpu agent queue or its label starts with "CPU-", so failures in these jobs don't block the pipeline. Existing soft_fail opt-ins are preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Force
soft_fail: trueon every generated Buildkite step that either:intel-cpuagent queue (AgentQueue.INTEL_CPU), orCPU-.Steps that already opt into
soft_failkeep it.Why
Failures in these jobs should not block the pipeline.
How
Added a
_should_soft_fail(step)helper inbuildkite/pipeline_generator/buildkite_step.pyand use it when constructing eachBuildkiteCommandStepinstead of passingstep.soft_faildirectly. The queue check reusesget_agent_queue(step), so it tracks however a step gets routed tointel-cpu.Verification
Sanity-checked the matcher against representative steps:
Some Intel test(deviceintel_cpu)intel-cpuCPU-1-test(devicecpu)cpu_queue_premerge_us_east_1CPU-2-no-devicegpu_1_queueGPU testgpu_1_queuewhatever(soft_fail=True)gpu_1_queuecpu lowercase test(devicecpu)cpu_queue_premerge_us_east_1The
CPU-match is case-sensitive and prefix-only, so it targets exactly theCPU-*named jobs without catching unrelated lowercasecpusteps.🤖 Generated with Claude Code