ci: pin split-score workflow to published v1.0.0 action#41
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Greptile SummaryThis PR makes two small but meaningful CI improvements to the Key changes:
Confidence Score: 5/5Safe to merge — changes are a straightforward CI hardening with no functional regressions. The only open finding (P2) is a best-practice suggestion to pin the action to an immutable commit SHA rather than the No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant PR as Pull Request Event
participant GH as GitHub Actions Runner
participant Checkout as actions/checkout@v4
participant Action as vitali87/pr-split@v1.0.0
participant Script as score_pr.py
participant API as GitHub REST API
PR->>GH: trigger (pull_request → main)
GH->>Checkout: fetch full history (fetch-depth: 0)<br/>permissions: contents: read
Checkout-->>GH: repository cloned
GH->>Action: run with max-loc, partition-strategy, threshold-groups
Action->>Script: execute scoring logic
Script-->>Action: outputs (total-loc, should-split, comment_path)
alt should-split == true
Action->>API: post/update PR comment<br/>permissions: pull-requests: write
end
Prompt To Fix All With AIThis is a comment left during a code review.
Path: .github/workflows/split-score.yml
Line: 20
Comment:
**Consider pinning to a commit SHA instead of a mutable tag**
`vitali87/pr-split@v1.0.0` is pinned to a tag, which is a mutable reference — the tag could be force-pushed to a different commit without changing this workflow file. GitHub's own security hardening guide recommends pinning third-party actions to a full commit SHA for supply-chain integrity.
```suggestion
uses: vitali87/pr-split@<full-commit-sha-of-v1.0.0>
```
You can find the SHA by running `git ls-remote https://github.com/vitali87/pr-split refs/tags/v1.0.0` and using the dereferenced (`^{}`) object SHA.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "ci: pin split-score workflow to publishe..." | Re-trigger Greptile |
|
|
||
| - uses: ./ | ||
| - name: pr-split score | ||
| uses: vitali87/pr-split@v1.0.0 |
There was a problem hiding this comment.
Consider pinning to a commit SHA instead of a mutable tag
vitali87/pr-split@v1.0.0 is pinned to a tag, which is a mutable reference — the tag could be force-pushed to a different commit without changing this workflow file. GitHub's own security hardening guide recommends pinning third-party actions to a full commit SHA for supply-chain integrity.
| uses: vitali87/pr-split@v1.0.0 | |
| uses: vitali87/pr-split@<full-commit-sha-of-v1.0.0> |
You can find the SHA by running git ls-remote https://github.com/vitali87/pr-split refs/tags/v1.0.0 and using the dereferenced (^{}) object SHA.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/split-score.yml
Line: 20
Comment:
**Consider pinning to a commit SHA instead of a mutable tag**
`vitali87/pr-split@v1.0.0` is pinned to a tag, which is a mutable reference — the tag could be force-pushed to a different commit without changing this workflow file. GitHub's own security hardening guide recommends pinning third-party actions to a full commit SHA for supply-chain integrity.
```suggestion
uses: vitali87/pr-split@<full-commit-sha-of-v1.0.0>
```
You can find the SHA by running `git ls-remote https://github.com/vitali87/pr-split refs/tags/v1.0.0` and using the dereferenced (`^{}`) object SHA.
How can I resolve this? If you propose a fix, please make it concise.
Summary
vitali87/pr-split@v1.0.0action instead of local./contents: readpermission required by checkoutTest plan