Split config loading and management into individual internal config package#33
Open
Janni2006 wants to merge 7 commits into
Open
Split config loading and management into individual internal config package#33Janni2006 wants to merge 7 commits into
Janni2006 wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the configuration management of the project by moving configuration logic from
main.gointo a new dedicatedinternal/configpackage. The new package provides structured configuration models, serialization (defaulting), and validation logic, leading to cleaner and more maintainable code. The main application now loads, serializes, and validates configuration using this package, and all references to configuration data inmain.goare updated accordingly.Configuration Refactor and Improvements:
internal/configpackage with structured configuration models (Config,OpencastConfig,DisplayConfig,MetricsConfig, etc.), including YAML tags for file parsing.serialize.goto set default values (e.g., default listen address, timeout, metrics endpoint) and trim trailing slashes from URLs.validate.goto ensure required configuration fields are present and valid (e.g., Opencast URL must not be empty, timeout must be positive).LoadFromFilemethod inmain.goto load, serialize, and validate configuration from a YAML file, replacing the previous hand-rolled loading logic. [1] [2] [3]Main Application Updates:
main.goto use the newconfig.Configstruct (cConfig) instead of the old inline struct, and removed the old configuration struct definitions and loading logic. [1] [2] [3] [4] [5] [6] [7]Configuration File Changes:
opencast-ca-display.ymlexample values for Opencast URL, agent, and timeout to reflect new defaults and test values. [1] [2]