Update home.html#356
Open
pratikktiwari wants to merge 1 commit into
Open
Conversation
Changed CSS float which caused problems with smaller screens. Used @media query: When screen with is lesser than 900px i.e., in case of mobile devices, reduce the padding of h2 and clear float.
|
Thanks for opening this pull request! 🤗 📢 Spread the word about @vinitshahdeo/Hacktoberfest2020 repo across your social media channels to help get others involved! Give a shoutout to Check out few other repos below 🚀 Show some ❤️
Say Hi on Twitter! 👋PS: Please add @vinitshahdeo as a reviewer if you haven't added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed CSS float which caused problems with smaller screens.
Used @media query: When screen with is lesser than 900px i.e., in case of mobile devices, reduce the padding of h2 and clear float.
Description
The float attribute attached to each tank container caused problems in devices with smaller screens.
h2 attribute was assigned padding of about 200px which was also causing problems.
Writing a simple media query for h2 and float worked and solved the issue.
Fixes # (issue)

BEFORE FIX
AFTER FIX

Type of change
Fix of CSS of home.html
Checklist:
Reviewer: Vinit Shahdeo