Skip to content

Landing Page Design instance-6#229

Open
habeeba-naaz wants to merge 82 commits into
vinitshahdeo:masterfrom
habeeba-naaz:landing-page-instance6
Open

Landing Page Design instance-6#229
habeeba-naaz wants to merge 82 commits into
vinitshahdeo:masterfrom
habeeba-naaz:landing-page-instance6

Conversation

@habeeba-naaz

Copy link
Copy Markdown

Description

Please review these design images placed in screenshots folder instance and let me know any changes to be done.
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #172

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

jainpawan21 and others added 30 commits February 27, 2020 11:53
I had updated the changes needed.

@amaaniqbal amaaniqbal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please tell me what steps you followed? It seems you always get stuck while creating a PR. There are so many unwanted commits attached to this PR.
Please let us know which commands you are trying and what are their corresponding outputs.

@habeeba-naaz

habeeba-naaz commented Apr 11, 2020

Copy link
Copy Markdown
Author

git checkout feature/frontend.
Make changes
git add screenshots folder path
git commit -m message
git push -u origin feature/fronted
if I use this command and push to that branch then I am getting linked to some other issues so I created new branch and pushed to new branch

@amaaniqbal

Copy link
Copy Markdown

Have you performed git pull upstream feature/frontend before checking out? Make sure that the latest commit listed in the upstream (feature/frontend branch in the repo) is the same as the one you are having locally. You can check for this via git log or maybe git log --oneline to get a minified version of the past commits.

@habeeba-naaz

Copy link
Copy Markdown
Author

Yes I used git pull upstream command but didn’t checked git log

@PragatiVerma18

Copy link
Copy Markdown
Contributor

@habeeba-naaz Please resolve merge conflicts and resubmit for review.

@PragatiVerma18 PragatiVerma18 added design design task gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue labels Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design design task gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create landing page design [easy/medium] - Instance #6