Poll for push destination readiness in connect_rtstream#79
Merged
Conversation
Push provisioning is async server-side, so connect_rtstream(ingest_mode=push) returns after polling until push_url is available (wait=True, timeout=180). Adds RTStream.refresh() and wait_until_ready().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78 (already merged). The polling change was pushed after #78 merged, so it never landed — this PR carries just that change.
What
Push provisioning is async server-side, so the client must wait for
push_url.connect_rtstream(ingest_mode="push", ...)returns after polling untilpush_urlis available (wait=True,timeout=180).RTStream.refresh()andRTStream.wait_until_ready().Pull behaviour is unchanged. Pairs with the server async PR.