You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It’s really annoying that every time you scan for devices, the four infrared devices are automatically added (if your smarphone supports ir).
I’ve moved them to the list of manual devices.
WDYT?
What if the phone / Windows does not support them? Adding something what is not supported looks weired.
How about adding some settings to disable IRDA (if it's supported) so as you can have it disabled if it annoys you?
Adding something what is not supported looks weired.
Yes, of course — it’s still [WIP] 😉
My suggestion would be to hide this device on the manual‑selection page whenever IRDA isn’t supported.
I mainly wanted to get your opinion on the approach and see whether you’d consider merging it before I invest more time.
Right now it’s only a LEGO IRDA implementation.
As a manually selectable device, it could later be extended with additional IRDA protocol implementations.
I.e. I have two Prio trains that are controlled via IRDA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It’s really annoying that every time you scan for devices, the four infrared devices are automatically added (if your smarphone supports ir).
I’ve moved them to the list of manual devices.
WDYT?