Skip to content

Add a global AppIdService to the application architecture #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
J0EK3R wants to merge 9 commits into
base: default
Choose a base branch
from
Open

Add a global AppIdService to the application architecture #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
19884e9
Add a global AppIdService to the application architecture
Jun 11, 2026
2d562db
added VendorBuilderTests
Jun 11, 2026
f4a127d
added JieStar SCM4 and JieStar SCM8 to VendorBuilderTests
Jun 11, 2026
512b31e
Bugfix: create new AppIdentifier if the requested length is *bigger *…
Jun 11, 2026
ce69d65
lock access to _appIdentifier to be threadsafe
Jun 11, 2026
502fdfe
new UnitTest MouldKingDeviceManagerTests.AppId_TwoBytesInPreferences_…
Jun 11, 2026
5a9e67a
new UnitTest JieStarDeviceManagerTests.AppId_TwoBytesInPreferences_Al…
Jun 11, 2026
3bb8d66
Potential fix for pull request finding
J0EK3R Jun 13, 2026
afe721f
Clarify interface summary for MouldKing device manager
J0EK3R Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions BrickController2/BrickController2.Tests/DeviceManagement/CaDA/CaDADeviceManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using BrickController2.DeviceManagement;
using BrickController2.DeviceManagement.CaDA;
using BrickController2.PlatformServices.BluetoothLE;
using BrickController2.UI.Services.AppIdentifier;
using BrickController2.UI.Services.Preferences;
using FluentAssertions;
using Moq;
Expand All @@ -17,10 +18,11 @@ public class CaDADeviceManagerTests

public CaDADeviceManagerTests()
{
_preferencesService.Setup(x => x.ContainsKey("AppID", "CaDA")).Returns(true);
_preferencesService.Setup(x => x.Get("AppID", "", "CaDA")).Returns("YWJj");
_preferencesService.Setup(x => x.ContainsKey("Identifier", "App")).Returns(true);
_preferencesService.Setup(x => x.Get("Identifier", "", "App")).Returns("YWJj");

_manager = new CaDADeviceManager(_preferencesService.Object, _cadaPlatformService.Object);
IAppIdentifierService appIdentifierService = new AppIdentifierService(_preferencesService.Object);
_manager = new CaDADeviceManager(appIdentifierService, _cadaPlatformService.Object);
}

[Fact]
Expand Down
Loading