perf(admin-log): add createdAt index for activity feed and retention policy#84
Open
Shrikant-sharma-9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a descending index on the
createdAtfield of theAdminLogmodel to optimize the primary query patterns used by the admin activity feed and the retention cleanup job.Rationale
A review of the current
AdminLogquery patterns identified two primary workloads:Activity Feed Retrieval
Retrieves all admin logs ordered by newest first.
Retention Policy Cleanup
Removes log entries older than the configured retention period.
A descending index on
createdAtallows MongoDB to efficiently satisfy both workloads by avoiding collection scans and in-memory sorting.A compound index such as
{ adminId: 1, createdAt: -1 }was considered but rejected because neither query filters onadminId. Since MongoDB uses the leading fields of a compound index, that index would not benefit these workloads.Verification
npx tsc --noEmitnpm run testBoth completed successfully.