fix: resolve four production correctness issues#116
Open
23f3001369 wants to merge 1 commit into
Open
Conversation
1. app.ts: fix frontendDistPath (was resolving to /app/frontend/dist which doesn't exist; correct path is ../../apps/frontend/dist matching the Dockerfile runtime stage COPY layout) 2. zoomOAuth.ts: fail fast in production if ZOOM_REDIRECT_URI is unset (previously defaulted to localhost silently, breaking OAuth callbacks) 3. .env.example: JWT_EXPIRES_IN now documents 15m (matching the actual auth.controller.ts default of 15m, not 7d which was a security risk) 4. docker-compose.prod.yml: add nginx/frontend service (was missing; backend only served the SPA in containers — now frontend is a proper separate service on port 80). Also add JWT_SECRET to backend env vars for defensive startup when .env is pre-populated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app.ts: fix frontendDistPath (was resolving to /app/frontend/dist which doesn't exist; correct path is ../../apps/frontend/dist matching the Dockerfile runtime stage COPY layout)
zoomOAuth.ts: fail fast in production if ZOOM_REDIRECT_URI is unset (previously defaulted to localhost silently, breaking OAuth callbacks)
.env.example: JWT_EXPIRES_IN now documents 15m (matching the actual auth.controller.ts default of 15m, not 7d which was a security risk)
docker-compose.prod.yml: add nginx/frontend service (was missing; backend only served the SPA in containers — now frontend is a proper separate service on port 80). Also add JWT_SECRET to backend env vars for defensive startup when .env is pre-populated.
What changed
Related issue
Type of change
Area affected
Checklist
cd backend && npx tsc --noEmit— cleancd frontend && npx tsc --noEmit— cleannpm testin affected package)main, no merge commitsNotes for reviewer